Merge lp:~mzanetti/unity8/panel-buttons-fixes into lp:unity8

Proposed by Michael Zanetti
Status: Rejected
Rejected by: Michael Zanetti
Proposed branch: lp:~mzanetti/unity8/panel-buttons-fixes
Merge into: lp:unity8
Diff against target: 49 lines (+13/-1)
2 files modified
qml/Shell.qml (+8/-0)
qml/Stages/DesktopStage.qml (+5/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/panel-buttons-fixes
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+256490@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

1711. By Michael Zanetti

some fixes for the panel buttons

1710. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Shell.qml'
--- qml/Shell.qml 2015-04-09 14:01:00 +0000
+++ qml/Shell.qml 2015-04-16 13:34:25 +0000
@@ -37,6 +37,7 @@
37import "Stages"37import "Stages"
38import "Tutorial"38import "Tutorial"
39import "Wizard"39import "Wizard"
40import "Components/PanelState"
40import Unity.Notifications 1.0 as NotificationBackend41import Unity.Notifications 1.0 as NotificationBackend
41import Unity.Session 0.142import Unity.Session 0.1
42import Unity.DashCommunicator 0.143import Unity.DashCommunicator 0.1
@@ -218,6 +219,13 @@
218 }219 }
219 }220 }
220221
222 Binding {
223 target: PanelState
224 property: "buttonsVisible"
225 value: false
226 when: usageModeSettings.usageMode !== "Windowed"
227 }
228
221 Loader {229 Loader {
222 id: applicationsDisplayLoader230 id: applicationsDisplayLoader
223 objectName: "applicationsDisplayLoader"231 objectName: "applicationsDisplayLoader"
224232
=== modified file 'qml/Stages/DesktopStage.qml'
--- qml/Stages/DesktopStage.qml 2015-03-13 19:18:35 +0000
+++ qml/Stages/DesktopStage.qml 2015-04-16 13:34:25 +0000
@@ -58,7 +58,7 @@
58 id: priv58 id: priv
5959
60 readonly property string focusedAppId: ApplicationManager.focusedApplicationId60 readonly property string focusedAppId: ApplicationManager.focusedApplicationId
61 readonly property var focusedAppDelegate: focusedAppId ? appRepeater.itemAt(indexOf(focusedAppId)) : null61 readonly property var focusedAppDelegate: focusedAppId && appRepeater.count == ApplicationManager.count ? appRepeater.itemAt(indexOf(focusedAppId)) : null
6262
63 function indexOf(appId) {63 function indexOf(appId) {
64 for (var i = 0; i < ApplicationManager.count; i++) {64 for (var i = 0; i < ApplicationManager.count; i++) {
@@ -85,6 +85,10 @@
85 value: priv.focusedAppDelegate !== null && priv.focusedAppDelegate.state === "maximized"85 value: priv.focusedAppDelegate !== null && priv.focusedAppDelegate.state === "maximized"
86 }86 }
8787
88 Component.onDestruction: {
89 PanelState.buttonsVisible = false;
90 }
91
88 Repeater {92 Repeater {
89 id: appRepeater93 id: appRepeater
90 model: ApplicationManager94 model: ApplicationManager

Subscribers

People subscribed via source and target branches