Merge ~mwhudson/grub/+git/ubuntu:multipath-root-typo into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: c4eac340b85dbcc0546188233c2cf831f05ce2d0
Proposed branch: ~mwhudson/grub/+git/ubuntu:multipath-root-typo
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 69 lines (+14/-6)
4 files modified
debian/.git-dpm (+2/-2)
debian/changelog (+8/-0)
debian/patches/ubuntu-boot-from-multipath-dependent-symlink.patch (+3/-3)
util/grub.d/10_linux.in (+1/-1)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+371182@code.launchpad.net

Description of the change

I made a booboo

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/.git-dpm b/debian/.git-dpm
index 3b1c29a..2e67c4d 100644
--- a/debian/.git-dpm
+++ b/debian/.git-dpm
@@ -1,6 +1,6 @@
1# see git-dpm(1) from git-dpm package1# see git-dpm(1) from git-dpm package
29c232f391a130bf7b12b60d0192a92ffdb5acc2127d601028aaa78434e8bae8f202afbae1d0d7cbc2
39c232f391a130bf7b12b60d0192a92ffdb5acc2137d601028aaa78434e8bae8f202afbae1d0d7cbc2
4578bb115fbd47e1c464696f1f8d6183e5443975d4578bb115fbd47e1c464696f1f8d6183e5443975d
5578bb115fbd47e1c464696f1f8d6183e5443975d5578bb115fbd47e1c464696f1f8d6183e5443975d
6grub2_2.04.orig.tar.xz6grub2_2.04.orig.tar.xz
diff --git a/debian/changelog b/debian/changelog
index 099155e..1f440f0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1grub2 (2.04-1ubuntu5) UNRELEASED; urgency=medium
2
3 * d/patches/ubuntu-boot-from-multipath-dependent-symlink.patch: fix
4 mis-spelling of helper function in final computation of GRUB_DEVICE in
5 multipath case.
6
7 -- Michael Hudson-Doyle <michael.hudson@ubuntu.com> Mon, 12 Aug 2019 11:07:51 +1200
8
1grub2 (2.04-1ubuntu4) eoan; urgency=medium9grub2 (2.04-1ubuntu4) eoan; urgency=medium
210
3 * d/patches/ubuntu-boot-from-multipath-dependent-symlink.patch: when / is11 * d/patches/ubuntu-boot-from-multipath-dependent-symlink.patch: when / is
diff --git a/debian/patches/ubuntu-boot-from-multipath-dependent-symlink.patch b/debian/patches/ubuntu-boot-from-multipath-dependent-symlink.patch
index 35d3787..5254adf 100644
--- a/debian/patches/ubuntu-boot-from-multipath-dependent-symlink.patch
+++ b/debian/patches/ubuntu-boot-from-multipath-dependent-symlink.patch
@@ -1,4 +1,4 @@
1From 9c232f391a130bf7b12b60d0192a92ffdb5acc21 Mon Sep 17 00:00:00 20011From 7d601028aaa78434e8bae8f202afbae1d0d7cbc2 Mon Sep 17 00:00:00 2001
2From: Michael Hudson-Doyle <michael.hudson@canonical.com>2From: Michael Hudson-Doyle <michael.hudson@canonical.com>
3Date: Tue, 6 Aug 2019 12:31:47 +12003Date: Tue, 6 Aug 2019 12:31:47 +1200
4Subject: UBUNTU: Boot from multipath-dependent symlink when / is multipathed.4Subject: UBUNTU: Boot from multipath-dependent symlink when / is multipathed.
@@ -16,7 +16,7 @@ Patch-Name: ubuntu-boot-from-multipath-dependent-symlink.patch
16 1 file changed, 41 insertions(+)16 1 file changed, 41 insertions(+)
1717
18diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in18diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
19index d6937cfef..8f3fbc41f 10064419index d6937cfef..3eb0e6936 100644
20--- a/util/grub.d/10_linux.in20--- a/util/grub.d/10_linux.in
21+++ b/util/grub.d/10_linux.in21+++ b/util/grub.d/10_linux.in
22@@ -65,6 +65,47 @@ esac22@@ -65,6 +65,47 @@ esac
@@ -60,7 +60,7 @@ index d6937cfef..8f3fbc41f 100644
60+ # using root=UUID= exposes the boot process to udev races. In addition60+ # using root=UUID= exposes the boot process to udev races. In addition
61+ # GRUB_DEVICE in this case will be /dev/dm-0 or similar -- better to use a61+ # GRUB_DEVICE in this case will be /dev/dm-0 or similar -- better to use a
62+ # symlink that depends on the multipath name.62+ # symlink that depends on the multipath name.
63+ GRUB_DEVICE=/dev/mapper/"$(get_dm_field_dev $GRUB_DEVICE name)"63+ GRUB_DEVICE=/dev/mapper/"$(get_dm_field_for_dev $GRUB_DEVICE name)"
64+ GRUB_DISABLE_LINUX_UUID=true64+ GRUB_DISABLE_LINUX_UUID=true
65+fi65+fi
66+66+
diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
index 8f3fbc4..3eb0e69 100644
--- a/util/grub.d/10_linux.in
+++ b/util/grub.d/10_linux.in
@@ -102,7 +102,7 @@ if test -e "${GRUB_DEVICE}" && is_multipath "${GRUB_DEVICE}"; then
102 # using root=UUID= exposes the boot process to udev races. In addition102 # using root=UUID= exposes the boot process to udev races. In addition
103 # GRUB_DEVICE in this case will be /dev/dm-0 or similar -- better to use a103 # GRUB_DEVICE in this case will be /dev/dm-0 or similar -- better to use a
104 # symlink that depends on the multipath name.104 # symlink that depends on the multipath name.
105 GRUB_DEVICE=/dev/mapper/"$(get_dm_field_dev $GRUB_DEVICE name)"105 GRUB_DEVICE=/dev/mapper/"$(get_dm_field_for_dev $GRUB_DEVICE name)"
106 GRUB_DISABLE_LINUX_UUID=true106 GRUB_DISABLE_LINUX_UUID=true
107fi107fi
108108

Subscribers

People subscribed via source and target branches