Merge lp:~mvo/software-center/whatsnew-leak-lp985389 into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 2999 |
Proposed branch: | lp:~mvo/software-center/whatsnew-leak-lp985389 |
Merge into: | lp:software-center |
Diff against target: |
66 lines (+12/-18) 3 files modified
softwarecenter/db/appfilter.py (+7/-0) softwarecenter/ui/gtk3/panes/availablepane.py (+3/-0) softwarecenter/ui/gtk3/panes/softwarepane.py (+2/-18) |
To merge this branch: | bzr merge lp:~mvo/software-center/whatsnew-leak-lp985389 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | Approve | ||
Review via email: mp+103424@code.launchpad.net |
Description of the change
This branch fixes bug #985389 where the filter restriction "installed-only" leaks into subsequent searches.
It also fixes the case where you are in "whats-new" (or any category with a filter restriction) and the searchaid logic suggests you to search "all-categories". This will also reset the non-global filters.
While working on it I removed some deadcode in softwarepane.py that is now part of searchaid.py but never got
cleaned up.
I would appreciate extra critical review/testing of this one as its potentially doing too much. I think we should be fine because global filters (like supported-only) are honored. And the installed-pane has no searchaid logic or categories so there should be no impact here. But I may overlook something of course :)
This looks good! Both test cases work perfectly, and I did a bunch more testing and found no ill effects, so I think this is good for merging. Note that I did find one small typo in the new reset() method of softwarecenter/ db/appfilter. py, which I have fixed.
This is a nice improvement, thank you, Michael!