Merge lp:~mvo/click/acquire-asyncio into lp:click/devel
Proposed by
Michael Vogt
Status: | Needs review |
---|---|
Proposed branch: | lp:~mvo/click/acquire-asyncio |
Merge into: | lp:click/devel |
Prerequisite: | lp:~mvo/click/acquire |
Diff against target: |
272 lines (+77/-100) 2 files modified
click/acquire.py (+69/-75) click/tests/test_acquire.py (+8/-25) |
To merge this branch: | bzr merge lp:~mvo/click/acquire-asyncio |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
click hackers | Pending | ||
Review via email: mp+236499@code.launchpad.net |
Commit message
Use asyncio for the method communication.
Description of the change
Simplify the non-blocking code in the subprocess handling by using the new asyncio. This means we will be python3+ only (unless we use the python-trollius compat module for python2 and older python3).
To post a comment you must log in.
Unmerged revisions
- 550. By Michael Vogt
-
refactor so that AcquireMethod.run() also uses asyncio
- 549. By Michael Vogt
-
port to asyncio
- 548. By Michael Vogt
-
add missing python3-dbus build-dependency
- 547. By Michael Vogt
-
rename read_messages() -> _read_messages()
- 546. By Michael Vogt
-
click/acquire.py: add note about ssl options for curl
- 545. By Michael Vogt
-
first round of addressing review points from Colin
- 544. By Michael Vogt
-
add python3-pycurl to b-d (needed during the tests
- 543. By Michael Vogt
-
add missing python3-pycurl depdendency
- 542. By Michael Vogt
-
click/acquire.py: make dbus optional
- 541. By Michael Vogt
-
remove debug message
FAILED: Continuous integration, rev:550 /code.launchpad .net/~mvo/ click/acquire- asyncio/ +merge/ 236499/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ click-devel- ci/89/ jenkins. qa.ubuntu. com/job/ click-devel- utopic- amd64-ci/ 91 jenkins. qa.ubuntu. com/job/ click-devel- utopic- armhf-ci/ 89 jenkins. qa.ubuntu. com/job/ click-devel- utopic- armhf-ci/ 89/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ click-devel- utopic- i386-ci/ 89
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/click- devel-ci/ 89/rebuild
http://