Merge lp:~mvo/aptdaemon/fix-659111 into lp:aptdaemon

[Michael Vogt]

Simple fix for #659111 - there is alternative approach, see the comment in the MP.

Unmerged revisions

699. By Michael Vogt on 2011-09-28

aptdaemon/worker.py: fix for #659111 with lengthy comment

=== modified file 'aptdaemon/worker.py'
--- aptdaemon/worker.py	2011-09-18 06:31:09 +0000
+++ aptdaemon/worker.py	2011-09-28 12:08:26 +0000
@@ -272,6 +272,17 @@
             self._mark_packages_for_downgrade(downgrade, resolver)
             self._resolve_depends(trans, resolver)
         self._check_obsoleted_dependencies(trans)
+        # do an additional resolver run to ensure that the autoremove
+        # never leaves the cache in a inconsistent state, see bug 
+        # LP: #659111 for the rational, essentially this may happen
+        # if a package is marked install during problem resolving but
+        # is later no longer required. the resolver deals with that
+        # 
+        # alternatively we need to add a addtional
+        #  "if pkg.marked_install and pkg.is_auto_removable: pkg.mark_keep()"
+        # to the _check_obsoleted_dependencies() (and fix python-apt to
+        # show is_auto_removable even when not installed)
+        self._resolve_depends(trans, resolver)
         if not simulate:
             self._apply_changes(trans)