Merge lp:~mterry/unity-greeter/fix-focus into lp:unity-greeter
Proposed by
Michael Terry
Status: | Merged |
---|---|
Merged at revision: | 516 |
Proposed branch: | lp:~mterry/unity-greeter/fix-focus |
Merge into: | lp:unity-greeter |
Diff against target: |
87 lines (+16/-10) 3 files modified
src/main-window.vala (+1/-1) src/menubar.vala (+1/-1) src/unity-greeter.vala (+14/-8) |
To merge this branch: | bzr merge lp:~mterry/unity-greeter/fix-focus |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Greeter Development Team | Pending | ||
Review via email: mp+107859@code.launchpad.net |
Description of the change
There are two problems currently with the focus-on-map logic:
1) The signature of the function was wrong, so vala was expecting the *this* pointer as the first argument, when it should have been expecting an XEvent pointer. This made our check for what type of event it was incorrect.
2) We shouldn't try to see if the window has requested not to be focused on map. For some reason, the shutdown dialog does that (though in my Unity session, compiz does focus it on map). This must be one of those vagaries of window managers. It doesn't hurt to focus everything as it comes by.
To post a comment you must log in.
Can you check this works with onboard? That code was changed so onboard didn't get focus: bazaar. launchpad. net/~unity- greeter- team/unity- greeter/ trunk/revision/ 363.1.1
http://