Merge lp:~mterry/telephony-service/no-screen-on into lp:telephony-service

Proposed by Michael Terry
Status: Needs review
Proposed branch: lp:~mterry/telephony-service/no-screen-on
Merge into: lp:telephony-service
Diff against target: 24 lines (+0/-15)
1 file modified
indicator/textchannelobserver.cpp (+0/-15)
To merge this branch: bzr merge lp:~mterry/telephony-service/no-screen-on
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+271699@code.launchpad.net

Commit message

Drop code that turns on screen upon receiving an MMS, because unity8 does that for us now when a notification appears.

Since unity8 8.11+15.04.20150831.2-0ubuntu1, the screen is automatically turned on when a notification is presented.

Description of the change

Drop code that turns on screen upon receiving an MMS, because unity8 does that for us now when a notification appears.

Since unity8 8.11+15.04.20150831.2-0ubuntu1, the screen is automatically turned on when a notification is presented.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

1121. By Michael Terry

Drop code that turns on screen, because unity8 does that for us now

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'indicator/textchannelobserver.cpp'
--- indicator/textchannelobserver.cpp 2015-07-23 01:25:44 +0000
+++ indicator/textchannelobserver.cpp 2015-09-18 18:13:02 +0000
@@ -395,21 +395,6 @@
395 }395 }
396 }396 }
397397
398 // WORKAROUND: powerd can't decide when to wake up the screen on incoming mms's
399 // (or other telepathy accounts) as the download of the attachments is made by
400 // another daemon, so we wake up the screen here.
401 if (!CallManager::instance()->hasCalls() &&
402 (mms || account->type() != AccountEntry::PhoneAccount)) {
403 QDBusInterface unityIface("com.canonical.Unity.Screen",
404 "/com/canonical/Unity/Screen",
405 "com.canonical.Unity.Screen",
406 QDBusConnection::systemBus());
407 QList<QVariant> args;
408 args.append("on");
409 args.append(0);
410 unityIface.callWithArgumentList(QDBus::NoBlock, "setScreenPowerMode", args);
411 }
412
413 // add the message to the messaging menu (use hex format to avoid invalid characters)398 // add the message to the messaging menu (use hex format to avoid invalid characters)
414 QByteArray token(message.messageToken().toUtf8());399 QByteArray token(message.messageToken().toUtf8());
415400

Subscribers

People subscribed via source and target branches