Merge ~mruffell/charm-grafana:lp1894011 into charm-grafana:master
Proposed by
Matthew Ruffell
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | James Hebden | ||||
Approved revision: | 5f1843b3f25e7ed7b4a117b3ef942a124fe5f137 | ||||
Merged at revision: | 534c1f1c9e05e02e66cd55087d29a360c4f6b83c | ||||
Proposed branch: | ~mruffell/charm-grafana:lp1894011 | ||||
Merge into: | charm-grafana:master | ||||
Diff against target: |
145 lines (+71/-4) 4 files modified
src/files/dashboards_backup (+2/-1) src/reactive/grafana.py (+5/-2) src/templates/juju-dashboards-backup.j2 (+1/-1) src/tests/functional/tests/test_grafana.py (+63/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Hebden (community) | Approve | ||
Chris Johnston (community) | Approve | ||
Drew Freiberger (community) | Approve | ||
Paul Goins | Needs Fixing | ||
Review via email: mp+390215@code.launchpad.net |
Commit message
Enable support for custom ports for dashboard backup
Currently dashboard backup uses a hardcoded base_url of localhost:3000,
which breaks the backup script if the user changes the port to anything
else.
Add some logic to fetch the port config and pass it into the dashboard
backup script. Also make sure dashboard backups are kept in sync with
any port changes.
LP: #1894011
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.