Merge lp:~mpt/ubiquity/3d-graphics-text into lp:ubiquity

Proposed by Matthew Paul Thomas
Status: Merged
Merged at revision: 5509
Proposed branch: lp:~mpt/ubiquity/3d-graphics-text
Merge into: lp:ubiquity
Diff against target: 12 lines (+1/-1)
1 file modified
gui/gtk/stepPrepare.ui (+1/-1)
To merge this branch: bzr merge lp:~mpt/ubiquity/3d-graphics-text
Reviewer Review Type Date Requested Status
Evan (community) Approve
Andrew Sinclair (community) legal Approve
Review via email: mp+110565@code.launchpad.net

Commit message

Adds mention of graphics drivers. Changes 'display' to 'play'. Changes 'wireless' to 'wi-fi'. Changes 'closed-source' to 'proprietary', matching Ubuntu Software Center. Removes repetition of 'the software'.

Description of the change

This branch changes the Ubuntu installer's third-party software text from this:

${RELEASE} uses third-party software to display Flash, MP3 and other media, and to work with some wireless hardware. Some of this software is closed-source. The software is subject to the license terms included with the software's documentation.

To this:

${RELEASE} uses third-party software to play Flash, MP3 and other media, and to work with some graphics and wi-fi hardware. Some of this software is proprietary. The software is subject to license terms included with its documentation.

The changes in case you missed them:
* Changes "display" to "play" (since MP3 is about audio, not video).
* Adds mention of graphics drivers (because the installer may install a Nvidia proprietary driver).
* Changes "wireless" to "wi-fi".
* Changes "closed-source" to "proprietary", matching Ubuntu Software Center.
* Removes repetition of "the software", by changing "the software's documentation" to "its documentation".

This paragraph is legally important, so changes should get legal review.

To post a comment you must log in.
Revision history for this message
Andrew Sinclair (andrew-sinclair) wrote :

I'm comfortable with the text changes. Are we distributing a graphics driver that was not part of the installer before?

review: Approve (legal)
lp:~mpt/ubiquity/3d-graphics-text updated
5508. By Matthew Paul Thomas

Removes the word '3-D'.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Andrew, thanks for the review. I don't know whether we were distributing it before, but the Nvidia graphics driver will now be installed if you have an Nvidia graphics card and check the checkbox. <https://github.com/tseliot/ubuntu-drivers-common/commit/3edabca8>

Revision history for this message
Evan (ev) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gui/gtk/stepPrepare.ui'
--- gui/gtk/stepPrepare.ui 2012-02-16 03:36:43 +0000
+++ gui/gtk/stepPrepare.ui 2012-06-19 08:50:24 +0000
@@ -119,7 +119,7 @@
119 <property name="visible">True</property>119 <property name="visible">True</property>
120 <property name="can_focus">False</property>120 <property name="can_focus">False</property>
121 <property name="xalign">0</property>121 <property name="xalign">0</property>
122 <property name="label" translatable="yes">${RELEASE} uses third-party software to display Flash, MP3 and other media, and to work with some wireless hardware. Some of this software is closed-source. The software is subject to the license terms included with the software's documentation.</property>122 <property name="label" translatable="yes">${RELEASE} uses third-party software to play Flash, MP3 and other media, and to work with some graphics and wi-fi hardware. Some of this software is proprietary. The software is subject to license terms included with its documentation.</property>
123 <property name="wrap">True</property>123 <property name="wrap">True</property>
124 </object>124 </object>
125 <packing>125 <packing>

Subscribers

People subscribed via source and target branches

to status/vote changes: