Merge lp:~mpontillo/maas/allow-commissioning-non-lts into lp:~maas-committers/maas/trunk
Status: | Rejected |
---|---|
Rejected by: | MAAS Lander |
Proposed branch: | lp:~mpontillo/maas/allow-commissioning-non-lts |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
235 lines (+82/-25) 6 files modified
src/provisioningserver/config.py (+14/-6) src/provisioningserver/drivers/osystem/tests/test_ubuntu.py (+30/-0) src/provisioningserver/drivers/osystem/ubuntu.py (+10/-2) src/provisioningserver/tests/test_config.py (+0/-7) src/provisioningserver/utils/config.py (+5/-4) src/provisioningserver/utils/tests/test_config.py (+23/-6) |
To merge this branch: | bzr merge lp:~mpontillo/maas/allow-commissioning-non-lts |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Needs Information | ||
Gavin Panella (community) | Approve | ||
Review via email: mp+307904@code.launchpad.net |
Commit message
Add option to rackd.conf that allows commissioning on non-LTS Ubuntu releases.
* New option: allow_commissio
* Drive-by fix for a bug that prevented usages of some validators
in the configuration subsystem, such as the StringBool.
(values were being returned as strings rather than bool)
Description of the change
If someone wants to test with a development release, currently they need to hack the MAAS code. This change allows a simple rackd.conf change (followed by reloading the global settings page) to relax the LTS-only restriction and allow that testing.
Unmerged revisions
- 5461. By Mike Pontillo
-
Merge allenap's fixes from lp:~allenap/maas/mpontillo--allow-commissioning-non-lts.
- 5460. By Mike Pontillo
-
Fix tests, address incorrect assumption.
- 5459. By Mike Pontillo
-
Add configuraiton option for commissioning on a non-LTS release. Drive-by fix for a problem that prevented correct usage of python conversions in rackd.conf.
- 5458. By Mike Pontillo
-
Add a constant to allow commissioning non-LTS releases.
Fixing the to_python/ from_python mix-up is great, but it's had some fallout. Try running bin/test.rack in full and you'll see what I mean. I have a fix for you though: https:/ /code.launchpad .net/~allenap/ maas/mpontillo- -allow- commissioning- non-lts/ +merge/ 307918. I haven't run bin/test.region though; life's too short for that ;)
I think the code here is grand, but I wonder if it's a good idea to put this into the rack configuration file. I'm not against the principle but I wonder if it will get abused. In that regard it's good that it cannot be configured with `maas-rack config`, and I think it should stay that way. My concern is probably premature though: let's see if we get bugs arising from misuse of this option and then consider what to do.
One question: on the region, when compiling the list of commissioning releases, do we intersect the responses from all racks? This setting may then be confusing in environments with multiple rack controllers, because non-LTS releases won't appear until all racks have been configured to allow them.