Merge ~morphis/netplan/+git/netplan:nm-snap-support into ~netplan-developers/netplan/+git/netplan-lp:master
Proposed by
Simon Fels
Status: | Rejected |
---|---|
Rejected by: | Martin Pitt |
Proposed branch: | ~morphis/netplan/+git/netplan:nm-snap-support |
Merge into: | ~netplan-developers/netplan/+git/netplan-lp:master |
Diff against target: |
82 lines (+35/-4) 1 file modified
src/netplan (+35/-4) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt (community) | Disapprove | ||
Review via email: mp+306607@code.launchpad.net |
Description of the change
Add support for the network-manager snap
If the network-manager snap is installed we should restart its service unit rather than the one of the debian package to get it to read its configuration files again.
To post a comment you must log in.
Having a different name for the well-known NetworkManager. service is ugly IMHO -- you are going to need to sprinkle this alternative name into every piece of software that tries to talk to it. And you can't possibly co-install it with the .deb as they would clash on D-Bus names.
So I'd really prefer to avoid patches like this, as they are super-ugly. I acknowledge that snapd presumably wants a canonical name like "snap.something", but the unit could just have "Alias= NetworkManager. service" to make it compatible with the deb.
I also have some inline comments, but they are hopefully moot with the Alias.