Merge lp:~mir-team/mir/fix-1577262 into lp:mir

[Daniel van Vugt]

Fix distorted screen rotation in Mir-on-X11 (LP: #1577262)

Just a quick proof of concept. No tests yet.

Using the mouse on a rotated screen remains confusing. That's not a new problem, but is worse on X11 as the host desktop is not rotated.

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:3489
https://mir-jenkins.ubuntu.com/job/mir-ci/928/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/982
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1028
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1019
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1019
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/992
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/992/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/992
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/992/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/992
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/992/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/992
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/992/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/992
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/992/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/928/rebuild

review: Approve (continuous-integration)

[Cemil Azizoglu (cemil-azizoglu)]

Ok

review: Approve

[Kevin DuBois (kdub)]

lgtm, would be good to have a test.

review: Approve

=== modified file 'src/platforms/mesa/server/x11/graphics/display_buffer.cpp'
--- src/platforms/mesa/server/x11/graphics/display_buffer.cpp	2016-04-19 18:20:17 +0000
+++ src/platforms/mesa/server/x11/graphics/display_buffer.cpp	2016-05-02 03:41:35 +0000
@@ -41,7 +41,14 @@
 
 geom::Rectangle mgx::DisplayBuffer::view_area() const
 {
-    return {{0,0}, size};
+    switch (orientation_)
+    {
+    case mir_orientation_left:
+    case mir_orientation_right:
+        return {{0,0}, {size.height.as_int(), size.width.as_int()}};
+    default:
+        return {{0,0}, size};
+    }
 }
 
 void mgx::DisplayBuffer::make_current()