Merge lp:~milo/lava-dashboard/get-test-names into lp:lava-dashboard

[Milo Casagrande]

Hi,

with this small branch here I added a simple XML-RPC 'get_test_names' to retrieve test names from lava-dashboard.

[Andy Doan (doanac)]

I have one small nitpick. Can you change the method signature from:

 def get_tests_names(self, device=None):

to

 def get_tests_names(self, device_type=None):

Just to keep the wording of things in code consistent.

[lp:~milo/lava-dashboard/get-test-names]

346. By Milo Casagrande on 2012-09-21

Renamed method argument.

[Milo Casagrande (milo)]

On Fri, Sep 21, 2012 at 4:39 PM, Andy Doan <email address hidden> wrote:
> I have one small nitpick. Can you change the method signature from:
>
> def get_tests_names(self, device=None):
>
> to
>
> def get_tests_names(self, device_type=None):
>
> Just to keep the wording of things in code consistent.

Absolutely!
This is now done.

Thanks.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

[lp:~milo/lava-dashboard/get-test-names]

347. By Milo Casagrande on 2012-09-25

Refactored method name.

[Milo Casagrande (milo)]

I refactored the method name, since it contained a typo: it was "get_tests_names" instead of "get_test_names".

[Andy Doan (doanac)]

I think this is sufficient for now. My team is discussing a real way to support this in the future, but I don't see anything in the MP that would hinder that process.

review: Approve

=== modified file 'dashboard_app/xmlrpc.py'
--- dashboard_app/xmlrpc.py	2012-03-15 03:09:06 +0000
+++ dashboard_app/xmlrpc.py	2012-09-25 10:58:30 +0000
@@ -38,6 +38,7 @@
     Bundle,
     BundleStream,
     DataView,
+    Test,
 )
 
 
@@ -407,6 +408,36 @@
             'is_deserialized': bundle.is_deserialized
             } for bundle in bundle_stream.bundles.all().order_by("uploaded_on")]
 
+    @xml_rpc_signature('str', 'str')
+    def get_test_names(self, device_type=None):
+        """
+        Name
+        ----
+        `get_test_names` ([`device`]])
+
+        Description
+        -----------
+        Get the name of all the tests ran.
+
+        Arguments
+        ---------
+        `device`: string
+            The type of device the retrieved test names should apply to.
+
+        Return value
+        ------------
+        This function returns an XML-RPC array of test names.
+        """
+        test_names = []
+        if device_type:
+            for test in Test.objects.filter(
+                test_runs__attributes__name='target.device_type',
+                test_runs__attributes__value=device_type).distinct():
+                test_names.append(test.name)
+        else:
+            for test in Test.objects.all():
+                test_names.append(test.name)
+        return test_names
 
     def deserialize(self, content_sha1):
         """