Merge lp:~miki-tebeka/gorun/gorun-md5 into lp:gorun
Proposed by
tebeka
Status: | Rejected |
---|---|
Rejected by: | Gustavo Niemeyer |
Proposed branch: | lp:~miki-tebeka/gorun/gorun-md5 |
Merge into: | lp:gorun |
Diff against target: |
83 lines (+23/-8) 1 file modified
gorun.go (+23/-8) |
To merge this branch: | bzr merge lp:~miki-tebeka/gorun/gorun-md5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Niemeyer | Pending | ||
Review via email: mp+54112@code.launchpad.net |
Description of the change
Using md5 signature instead of time stamps. This simplifies the logic of "do we need to recompile" and also protects from clock skew.
To post a comment you must log in.
I believe we talked about that elsewhere at the time. Computing the md5 all the time on a file content is unnecessary.