Merge lp:~michael-sheldon/content-hub/fix-1390096-rtm into lp:content-hub/rtm-14.09

Proposed by Michael Sheldon
Status: Merged
Approved by: Bill Filler
Approved revision: 139
Merged at revision: 140
Proposed branch: lp:~michael-sheldon/content-hub/fix-1390096-rtm
Merge into: lp:content-hub/rtm-14.09
Diff against target: 35 lines (+2/-1)
3 files modified
import/Ubuntu/Content/ContentPeerPicker10.qml (+1/-0)
import/Ubuntu/Content/ContentPeerPicker11.qml (+1/-0)
import/Ubuntu/Content/contentpeermodel.cpp (+0/-1)
To merge this branch: bzr merge lp:~michael-sheldon/content-hub/fix-1390096-rtm
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+246881@code.launchpad.net

Commit message

Cherry pick fix for displaying "No applications available" message from trunk

Description of the change

Cherry pick fix for displaying "No applications available" message from trunk

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes (in sync with RTM branch)

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'import/Ubuntu/Content/ContentPeerPicker10.qml'
--- import/Ubuntu/Content/ContentPeerPicker10.qml 2014-10-10 15:28:39 +0000
+++ import/Ubuntu/Content/ContentPeerPicker10.qml 2015-01-19 11:48:20 +0000
@@ -51,6 +51,7 @@
51 Loader {51 Loader {
52 id: peerModelLoader52 id: peerModelLoader
53 active: false53 active: false
54 asynchronous: true
54 sourceComponent: ContentPeerModel { }55 sourceComponent: ContentPeerModel { }
55 onLoaded: {56 onLoaded: {
56 item.handler = root.handler;57 item.handler = root.handler;
5758
=== modified file 'import/Ubuntu/Content/ContentPeerPicker11.qml'
--- import/Ubuntu/Content/ContentPeerPicker11.qml 2014-10-10 15:28:39 +0000
+++ import/Ubuntu/Content/ContentPeerPicker11.qml 2015-01-19 11:48:20 +0000
@@ -68,6 +68,7 @@
68 Loader {68 Loader {
69 id: peerModelLoader69 id: peerModelLoader
70 active: false70 active: false
71 asynchronous: true
71 sourceComponent: ContentPeerModel { }72 sourceComponent: ContentPeerModel { }
72 onLoaded: {73 onLoaded: {
73 item.handler = root.handler;74 item.handler = root.handler;
7475
=== modified file 'import/Ubuntu/Content/contentpeermodel.cpp'
--- import/Ubuntu/Content/contentpeermodel.cpp 2014-08-05 21:01:22 +0000
+++ import/Ubuntu/Content/contentpeermodel.cpp 2015-01-19 11:48:20 +0000
@@ -95,7 +95,6 @@
95void ContentPeerModel::findPeers() {95void ContentPeerModel::findPeers() {
96 TRACE() << Q_FUNC_INFO;96 TRACE() << Q_FUNC_INFO;
97 m_peers.clear();97 m_peers.clear();
98 QCoreApplication::processEvents();
99 if(m_contentType == ContentType::All) {98 if(m_contentType == ContentType::All) {
100 appendPeersForContentType(ContentType::Documents);99 appendPeersForContentType(ContentType::Documents);
101 appendPeersForContentType(ContentType::Pictures);100 appendPeersForContentType(ContentType::Pictures);

Subscribers

People subscribed via source and target branches