Merge lp:~mhr3/unity/places-group-focus-overlay into lp:unity

[Michal Hruby]

Don't compare entire geometry when re-rendering focus overlay in PlacesGroup

PlacesGroup::ComputeContentSize was unnecessarily re-rendering the focus overlay because it was comparing the entire geometry (pos + size) while only the width matters for the overlay.

[Andrea Azzarone (azzar1)]

Cool. I think we don't need to store the _ached_geometry too. We can just store the width.

[Michal Hruby (mhr3)]

I kept it in case we wanted to account for the height as well at some point, but yes atm only width would suffice.

[Marco Trevisan (Treviño) (3v1n0)]

+1

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1016/console reported an error when processing this lp:~mhr3/unity/places-group-focus-overlay branch.
Not merging it.

=== modified file 'dash/PlacesGroup.cpp'
--- dash/PlacesGroup.cpp	2012-06-18 02:57:23 +0000
+++ dash/PlacesGroup.cpp	2012-08-05 22:28:18 +0000
@@ -369,7 +369,8 @@
 
   nux::Geometry const& geo = GetGeometry();
 
-  if (_cached_geometry != geo)
+  // only the width matters
+  if (_cached_geometry.GetWidth() != geo.GetWidth())
   {
     _focus_layer.reset(dash::Style::Instance().FocusOverlay(geo.width - kHighlightLeftPadding - kHighlightRightPadding, kHighlightHeight));