Merge lp:~mhr3/unity-lens-shopping/hide-errors into lp:unity-lens-shopping
Proposed by
Michal Hruby
Status: | Merged |
---|---|
Approved by: | Michal Hruby |
Approved revision: | 30 |
Merged at revision: | 28 |
Proposed branch: | lp:~mhr3/unity-lens-shopping/hide-errors |
Merge into: | lp:unity-lens-shopping |
Diff against target: |
80 lines (+26/-5) 2 files modified
src/scope.vala (+12/-5) tests/manual-tests/shopping-lens-tests.txt (+14/-0) |
To merge this branch: | bzr merge lp:~mhr3/unity-lens-shopping/hide-errors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paweł Stołowski (community) | Approve | ||
Review via email: mp+127554@code.launchpad.net |
Commit message
Show empty preview on network issues, chug input strings instead of stripping them
Description of the change
Currently if it's not possible to get preview for a result (due to for example network issue). A preview is displayed with description that shows the error message from libsoup, although handy for development, this isn't desired to be shown to the user. (also includes a tiny closure data leak fix)
To post a comment you must log in.
Could you please add a manual test for error case?