Merge lp:~mhr3/dee/fix-1246263 into lp:dee

[Michal Hruby]

Disconnect signal handlers when unreffing GDBusServer.

Disconnect signal handlers when unreffing GDBusServer, not doing so could have caused a critical during tests (as seen in lp:libunity).

[Michal Hruby (mhr3)]

I ran libunity's test-scope tests around 1000 times and I didn't see any more dee related criticals (without the patch I saw it after about 200 test runs).

I did see one gio-related race, opened a new bug on bgo for that.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:431
http://jenkins.qa.ubuntu.com/job/dee-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/dee-trusty-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-i386-ci/1

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dee-ci/13/rebuild

review: Approve (continuous-integration)

[Paweł Stołowski (stolowski)]

LGTM. +1

review: Approve

=== modified file 'src/dee-server.c'
--- src/dee-server.c	2012-01-26 14:08:54 +0000
+++ src/dee-server.c	2013-10-30 12:15:43 +0000
@@ -364,6 +364,8 @@
 
   if (priv->server)
     {
+      g_signal_handlers_disconnect_by_func (priv->server, on_new_connection, object);
+
       /* this should be done automatically on unref, but it doesn't seem so */
       g_dbus_server_stop (priv->server);