Merge lp:~mh0/ubuntu-drupal-theme/6.x-2010 into lp:ubuntu-drupal-theme

Proposed by Micheal Harker
Status: Needs review
Proposed branch: lp:~mh0/ubuntu-drupal-theme/6.x-2010
Merge into: lp:ubuntu-drupal-theme
Diff against target: 38 lines (+3/-4)
1 file modified
styles/base.css (+3/-4)
To merge this branch: bzr merge lp:~mh0/ubuntu-drupal-theme/6.x-2010
Reviewer Review Type Date Requested Status
Michael Lustfield (community) Needs Fixing
Review via email: mp+42286@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

This merge would involve applying a static minimum width to an element that as a configurable minimum width available from the theme settings.

A min-width should not be used to fix this and should instead be used to decide where horizontal scrolling starts.

In addition, the min-width should not be decided on by the designer but rather by the person using the theme.

review: Needs Fixing
lp:~mh0/ubuntu-drupal-theme/6.x-2010 updated
76. By Micheal Harker <michealh@michealh-laptop>

Fixed header using margin: -9px auto 0;

77. By Micheal Harker <michealh@michealh-laptop>

Fixed issues

78. By Micheal Harker <michealh@michealh-laptop>

Fixed a silly mistake

79. By Micheal Harker <michealh@michealh-laptop>

Trying something else

80. By Micheal Harker <michealh@michealh-laptop>

Fixed broken header

Unmerged revisions

80. By Micheal Harker <michealh@michealh-laptop>

Fixed broken header

79. By Micheal Harker <michealh@michealh-laptop>

Trying something else

78. By Micheal Harker <michealh@michealh-laptop>

Fixed a silly mistake

77. By Micheal Harker <michealh@michealh-laptop>

Fixed issues

76. By Micheal Harker <michealh@michealh-laptop>

Fixed header using margin: -9px auto 0;

75. By Micheal Harker <michealh@michealh-laptop>

For my first merge proposal into lp:ubuntu-drupal-theme

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'styles/base.css'
--- styles/base.css 2010-09-10 02:43:22 +0000
+++ styles/base.css 2010-11-30 21:59:09 +0000
@@ -39,10 +39,10 @@
3939
40#header {40#header {
41 height: 70px;41 height: 70px;
42 margin: 0px;
43 padding: 0 5px;42 padding: 0 5px;
44 position: relative;43 position: relative;
45 font-size: 14px;44 font-size: 14px;
45 margin: -9px auto 0;
46}46}
4747
48#header li {48#header li {
@@ -184,13 +184,11 @@
184184
185#content {185#content {
186 line-height: 1.4em;186 line-height: 1.4em;
187 overflow: hidden;
188}187}
189188
190#content .container {189#content .container {
191 margin-top: -9px;
192 padding: 20px 0;190 padding: 20px 0;
193 overflow: hidden;191 margin: -9px auto 0;
194}192}
195193
196#page-content {194#page-content {
@@ -361,6 +359,7 @@
361 font-size: 11px;359 font-size: 11px;
362 width: 100%;360 width: 100%;
363 display: table;361 display: table;
362margin: -9px auto 0;
364}363}
365364
366#footer .block {365#footer .block {

Subscribers

People subscribed via source and target branches