Merge lp:~mefrio-g/pantheon-notify/fix-986822 into lp:~tombeckmann/pantheon-notify/trunk

[Mario Guerriero]

[Victor Martinez (victored)]

It would be better if you escaped the text before setting the markup. For instance:

name = Markup.escape (name, -1);
body = Markup.escape (body -1);
text.set_markup ("<span font='10' weight='bold'>" + name + "</span>\n<span font='9'>" + body + "</span>");

review: Needs Fixing

Unmerged revisions

18. By Mario Guerriero on 2012-04-22

fixed bug #986822

=== modified file 'src/notification.vala'
--- src/notification.vala	2012-04-21 20:01:07 +0000
+++ src/notification.vala	2012-04-22 13:17:18 +0000
@@ -276,8 +276,8 @@
     }
     
     public void set_text (string name, string body) {
-        text.text = "<span font='10' weight='bold'>"+name+"</span>\n<span font='9'>"+body+"</span>";
         text.use_markup = true;
+        text.set_markup ("<span font='10' weight='bold'>"+name+"</span>\n<span font='9'>"+body+"</span>");
     }
     
     public void close (bool fast_close=false) {