Merge lp:~matthew.revell/launchpad/tour-commercial-tweak-bug-393348 into lp:launchpad/db-devel

Proposed by Matthew Revell
Status: Work in progress
Proposed branch: lp:~matthew.revell/launchpad/tour-commercial-tweak-bug-393348
Merge into: lp:launchpad/db-devel
Diff against target: 21 lines (+2/-2)
1 file modified
lib/canonical/launchpad/tour/join-launchpad (+2/-2)
To merge this branch: bzr merge lp:~matthew.revell/launchpad/tour-commercial-tweak-bug-393348
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+17808@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Fixes the VAT rate and clarifies some wording on the join-launchpad page of the tour.

Revision history for this message
Brad Crittenden (bac) wrote :

As we discussed on IRC I think you should strike the word 'new' at line 9 of the diff. Otherwise it's great. Thanks for the corrections.

review: Approve (code)
10196. By Matthew Revell

Changes following bac's review

10197. By Matthew Revell

Changes following bac's review.

Revision history for this message
Aaron Bentley (abentley) wrote :

It seems unlikely that a branch this old will merge cleanly, therefore, I am marking it work-in-progress.

Unmerged revisions

10197. By Matthew Revell

Changes following bac's review.

10196. By Matthew Revell

Changes following bac's review

10195. By Matthew Revell

Merge from RF

10194. By Matthew Revell

Changes VAT to 17.5% and clarifies the privacy features texts. Fixes bugs 393348 and 509720.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/tour/join-launchpad'
--- lib/canonical/launchpad/tour/join-launchpad 2010-01-08 20:39:15 +0000
+++ lib/canonical/launchpad/tour/join-launchpad 2010-01-21 15:10:33 +0000
@@ -65,7 +65,7 @@
65 <p class="screen-holder">65 <p class="screen-holder">
66 <img src="images/join/1.png" alt="Commercial subscriptions" /> </p>66 <img src="images/join/1.png" alt="Commercial subscriptions" /> </p>
67 <p>Get all the benefits of hosting your closed-source project on Launchpad for just $250* a year. Easily share bug reports, code and more across your development community and, optionally, plug into the open source projects you rely on.</p><br />67 <p>Get all the benefits of hosting your closed-source project on Launchpad for just $250* a year. Easily share bug reports, code and more across your development community and, optionally, plug into the open source projects you rely on.</p><br />
68 <p> At the same time, get an exclusive preview of our new privacy features, including:</p><br />68 <p>At the same time, try out our privacy features, including:</p><br />
69 <ul>69 <ul>
70 <li>private code branches</li>70 <li>private code branches</li>
71 <li>private bugs by default</li>71 <li>private bugs by default</li>
@@ -74,7 +74,7 @@
74 </ul><br />74 </ul><br />
75 <p>To get going, register your project and select <em>Other/Proprietary</em> as its licence.</p><br />75 <p>To get going, register your project and select <em>Other/Proprietary</em> as its licence.</p><br />
76 <p>Want to know more? <a href="mailto:commercial@launchpad.net">Get in touch</a>!</p><br />76 <p>Want to know more? <a href="mailto:commercial@launchpad.net">Get in touch</a>!</p><br />
77 <p><small>* US Dollars. Add VAT at 15% if you're in the European Union. Subscription is per project. Privacy features may incur additional charges after the beta.</small></p>77 <p><small>* US Dollars. Add VAT at 17.5% if you're in the European Union. Subscription is per project. Prices may change in the future.</small></p>
78 <p style="float: right;"><a href="https://launchpad.net/projects/+new">Register your project &gt;</a></p><br />78 <p style="float: right;"><a href="https://launchpad.net/projects/+new">Register your project &gt;</a></p><br />
7979
80 </p>80 </p>

Subscribers

People subscribed via source and target branches

to status/vote changes: