Merge lp:~mardy/account-plugins/onedrive_provider into lp:~gary-wzl77/account-plugins/onedrive_provider

Proposed by Alberto Mardegan
Status: Needs review
Proposed branch: lp:~mardy/account-plugins/onedrive_provider
Merge into: lp:~gary-wzl77/account-plugins/onedrive_provider
Diff against target: 48 lines (+8/-7)
2 files modified
data/providers/microsoft.provider.in.in (+1/-1)
qml/microsoft/Main.qml (+7/-6)
To merge this branch: bzr merge lp:~mardy/account-plugins/onedrive_provider
Reviewer Review Type Date Requested Status
Gary.Wang Pending
Review via email: mp+309841@code.launchpad.net

Description of the change

Use new api to get username, log errors.

To post a comment you must log in.

Unmerged revisions

181. By Alberto Mardegan

Update plugin to new API

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/providers/microsoft.provider.in.in'
--- data/providers/microsoft.provider.in.in 2016-10-26 11:47:38 +0000
+++ data/providers/microsoft.provider.in.in 2016-11-02 12:04:34 +0000
@@ -17,7 +17,7 @@
17 <setting name="RedirectUri">https://login.live.com/oauth20_desktop.srf</setting>17 <setting name="RedirectUri">https://login.live.com/oauth20_desktop.srf</setting>
18 <setting name="ResponseType">token</setting>18 <setting name="ResponseType">token</setting>
19 <setting name="ClientId">@MICROSOFT_CLIENT_ID@</setting>19 <setting name="ClientId">@MICROSOFT_CLIENT_ID@</setting>
20 <setting type="as" name="Scope">['onedrive.readwrite onedrive.appfolder']</setting> 20 <setting type="as" name="Scope">['onedrive.readwrite', 'onedrive.appfolder']</setting>
21 <setting type="b" name="DisableStateParameter">true</setting>21 <setting type="b" name="DisableStateParameter">true</setting>
22 </group>22 </group>
23 </group>23 </group>
2424
=== modified file 'qml/microsoft/Main.qml'
--- qml/microsoft/Main.qml 2016-11-02 08:34:54 +0000
+++ qml/microsoft/Main.qml 2016-11-02 12:04:34 +0000
@@ -2,7 +2,7 @@
22
3OAuthMain {3OAuthMain {
4 creationComponent: OAuth {4 creationComponent: OAuth {
5 function getUserName(reply) {5 function getUserName(reply, callback) {
6 var http = new XMLHttpRequest();6 var http = new XMLHttpRequest();
7 var url = "https://api.onedrive.com/v1.0/drive";7 var url = "https://api.onedrive.com/v1.0/drive";
8 http.open("GET", url, true);8 http.open("GET", url, true);
@@ -11,16 +11,17 @@
11 if (http.readyState === 4) {11 if (http.readyState === 4) {
12 if (http.status === 200) {12 if (http.status === 200) {
13 var response = JSON.parse(http.responseText);13 var response = JSON.parse(http.responseText);
14 account.updateDisplayName(response.owner.user.displayName +14 callback(response.owner.user.displayName +
15 " ( id: " + response.owner.user.id + ")");15 " ( id: " + response.owner.user.id + ")");
16 account.synced.connect(finished);
17 account.sync();
18 } else {16 } else {
17 console.log("error: " + http.status);
18 console.log("response text: " + http.responseText);
19 cancel();19 cancel();
20 }20 }
21 }21 }
22 };22 };
23 http.send(null);23 http.send(null);
24 return true;
24 }25 }
25 } 26 }
26}27}

Subscribers

People subscribed via source and target branches

to all changes: