Merge lp:~mardy/account-plugins/new-oauth-plugin into lp:account-plugins

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: 140
Merged at revision: 140
Proposed branch: lp:~mardy/account-plugins/new-oauth-plugin
Merge into: lp:account-plugins
Diff against target: 39 lines (+9/-1)
3 files modified
configure.ac (+1/-1)
data/providers/google.provider.in.in (+1/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~mardy/account-plugins/new-oauth-plugin
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
David Barth (community) Approve
Review via email: mp+234060@code.launchpad.net

Commit message

Google: add ForceClientAuthViaRequestBody flag

The next version of signon-plugin-oauth2 will use HTTP Basic authorization for
authorizing the client, as recommended by the OAuth 2.0 specification. However,
Google does not support it, and therefore we need to add this special flag to
force the oauth2 plugin to authenticate the client by passing ClientId and
ClientSecret in the request body.
We don't need to update the dependency version, because older versions of
signon-plugin-oauth2 will simply ignore this flag.

Description of the change

Google: add ForceClientAuthViaRequestBody flag

The next version of signon-plugin-oauth2 will use HTTP Basic authorization for
authorizing the client, as recommended by the OAuth 2.0 specification. However,
Google does not support it, and therefore we need to add this special flag to
force the oauth2 plugin to authenticate the client by passing ClientId and
ClientSecret in the request body.
We don't need to update the dependency version, because older versions of
signon-plugin-oauth2 will simply ignore this flag.

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
140. By Alberto Mardegan

Version 0.12

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2013-06-12 05:49:46 +0000
+++ configure.ac 2014-09-11 10:07:46 +0000
@@ -1,7 +1,7 @@
1dnl Process this file with autoconf to produce a configure script.1dnl Process this file with autoconf to produce a configure script.
22
3AC_INIT([account-plugins],3AC_INIT([account-plugins],
4 [0.11],4 [0.12],
5 [https://bugs.launchpad.net/online-accounts-account-plugins/+filebug],5 [https://bugs.launchpad.net/online-accounts-account-plugins/+filebug],
6 [account-plugins],6 [account-plugins],
7 [https://launchpad.net/online-accounts-account-plugins])7 [https://launchpad.net/online-accounts-account-plugins])
88
=== modified file 'data/providers/google.provider.in.in'
--- data/providers/google.provider.in.in 2014-03-07 15:03:19 +0000
+++ data/providers/google.provider.in.in 2014-09-11 10:07:46 +0000
@@ -23,6 +23,7 @@
23 <setting name="ClientId">@GOOGLE_CLIENT_ID@</setting>23 <setting name="ClientId">@GOOGLE_CLIENT_ID@</setting>
24 <setting name="ClientSecret">@GOOGLE_CLIENT_SECRET@</setting>24 <setting name="ClientSecret">@GOOGLE_CLIENT_SECRET@</setting>
25 <setting name="AllowedSchemes" type="as">['https','http']</setting>25 <setting name="AllowedSchemes" type="as">['https','http']</setting>
26 <setting name="ForceClientAuthViaRequestBody" type="b">true</setting>
26 </group>27 </group>
27 </group>28 </group>
28 </group>29 </group>
2930
=== modified file 'debian/changelog'
--- debian/changelog 2014-04-09 17:58:26 +0000
+++ debian/changelog 2014-09-11 10:07:46 +0000
@@ -1,3 +1,10 @@
1account-plugins (0.12-0ubuntu1) UNRELEASED; urgency=medium
2
3 * Google: add ForceClientAuthViaRequestBody flag, required by the new
4 signon-plugin-oauth2
5
6 -- Alberto Mardegan <alberto.mardegan@canonical.com> Thu, 11 Sep 2014 13:04:44 +0300
7
1account-plugins (0.11+14.04.20140409.1-0ubuntu1) trusty; urgency=low8account-plugins (0.11+14.04.20140409.1-0ubuntu1) trusty; urgency=low
29
3 [ Ubuntu daily release ]10 [ Ubuntu daily release ]

Subscribers

People subscribed via source and target branches