Merge lp:~marcustomlinson/storage-framework/fix-for-dev-ppa into lp:storage-framework/devel

Proposed by Marcus Tomlinson
Status: Merged
Approved by: Michi Henning
Approved revision: 30
Merged at revision: 30
Proposed branch: lp:~marcustomlinson/storage-framework/fix-for-dev-ppa
Merge into: lp:storage-framework/devel
Prerequisite: lp:~michihenning/storage-framework/fix-version-typo
Diff against target: 12 lines (+1/-1)
1 file modified
tests/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~marcustomlinson/storage-framework/fix-for-dev-ppa
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
Review via email: mp+300754@code.launchpad.net

This proposal supersedes a proposal from 2016-07-21.

Commit message

Temporary fix to get storage-framework building in CI

To post a comment you must log in.
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote : Posted in a previous version of this proposal

Got this when building in the dev-build-4 PPA

test 2
      Start 2: remote-client

2: Test command: /«PKGBUILDDIR»/obj-x86_64-linux-gnu/tests/remote-client/remote-client_test
2: Test timeout computed to be: 1500
2: [==========] Running 6 tests from 4 test cases.
2: [----------] Global test environment set-up.
2: [----------] 3 tests from RuntimeTest
2: [ RUN ] RuntimeTest.lifecycle
2: GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
2: Bus unique name: ":1.2"
2: g_dbus_connection_real_closed: Remote peer vanished with error: Underlying GIOStream returned 0 bytes on an async read (g-io-error-quark, 0). Exiting.
2: [ OK ] RuntimeTest.lifecycle (101 ms)
2: [ RUN ] RuntimeTest.basic
2: GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
2: Bus unique name: ":1.2"
2: GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
2: Cannot find any online account
2: Configure at least one online account for a provider in System Settings -> Online Accounts
 2/13 Test #2: remote-client ........................................................***Exception: SegFault 1.14 sec
[==========] Running 6 tests from 4 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from RuntimeTest
[ RUN ] RuntimeTest.lifecycle
GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
Bus unique name: ":1.2"
g_dbus_connection_real_closed: Remote peer vanished with error: Underlying GIOStream returned 0 bytes on an async read (g-io-error-quark, 0). Exiting.
[ OK ] RuntimeTest.lifecycle (101 ms)
[ RUN ] RuntimeTest.basic
GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
Bus unique name: ":1.2"
GetAccounts call failed: QDBusError("org.freedesktop.DBus.Error.UnknownMethod", "No such interface 'com.ubuntu.OnlineAccounts.Manager' on object at path /com/ubuntu/OnlineAccounts/Manager")
Cannot find any online account
Configure at least one online account for a provider in System Settings -> Online Accounts

Revision history for this message
Michi Henning (michihenning) wrote : Posted in a previous version of this proposal

This is OK to get you unstuck. But please add a TODO: comment and explain why this is turned off and that it needs to be turned back on again.

You will need to merge manually.

review: Needs Fixing
30. By Marcus Tomlinson

Fix for building in dev PPA

Revision history for this message
Michi Henning (michihenning) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2016-07-12 06:42:53 +0000
+++ tests/CMakeLists.txt 2016-07-21 12:38:21 +0000
@@ -13,7 +13,7 @@
1313
14set(unit_test_dirs14set(unit_test_dirs
15 local-client15 local-client
16 remote-client16# remote-client -TODO: Temporarily disabled due to a "Cannot find any online account" error in CI.
17)17)
1818
19set(slow_test_dirs19set(slow_test_dirs

Subscribers

People subscribed via source and target branches