Merge lp:~marcokarlo/indicator-datetime/ubuntu14.10rtm into lp:indicator-datetime/15.10

Proposed by Marco A. Harrendorf
Status: Needs review
Proposed branch: lp:~marcokarlo/indicator-datetime/ubuntu14.10rtm
Merge into: lp:indicator-datetime/15.10
Diff against target: 121 lines (+59/-8) (has conflicts)
3 files modified
debian/changelog (+49/-2)
src/snap.cpp (+9/-0)
src/wakeup-timer-powerd.cpp (+1/-6)
Text conflict in debian/changelog
Text conflict in src/snap.cpp
To merge this branch: bzr merge lp:~marcokarlo/indicator-datetime/ubuntu14.10rtm
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+259315@code.launchpad.net

Description of the change

Up to now a short notification for calendar reminders is only shown.
It is important that the notification is also shown in the notification area, so that one can have a look on missed reminders.

To post a comment you must log in.

Unmerged revisions

401. By Marco A. Harrendorf

Snap.cc: Show notifications for calendar entry if missed

400. By CI Train Bot Account

Releasing 13.10.0+15.04.20150318~rtm-0ubuntu1

399. By Charles Kerr

Work around glib's type initialization deadlock.

https://bugzilla.gnome.org/show_bug.cgi?id=674885 Fixes: #1425297
Approved by: Ted Gould

398. By CI Train Bot Account

Releasing 13.10.0+15.04.20150226~rtm-0ubuntu1

397. By Charles Kerr

Avoid ECANCELED errors in calls to timerfd_settime() Fixes: #1424966
Approved by: Ted Gould

396. By CI Train Bot Account

Releasing 13.10.0+15.04.20150213~rtm-0ubuntu1

395. By Charles Kerr

change the WallClock to detect time changes from TFD_TIMER_CANCEL_ON_SET, e.g. when ntp<-->manual is toggled
Approved by: Ted Gould

394. By CI Train Bot Account

Releasing 13.10.0+15.04.20150122~rtm-0ubuntu1

393. By Charles Kerr

Don't play calendar alarm sounds if Silent Mode is enabled. Use the alarm sound role for both clock and calendar alarms. Fixes: #1410874
Approved by: Antti Kaijanmäki

392. By CI Train Bot Account

Releasing 13.10.0+15.04.20150115~rtm-0ubuntu1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-05-15 16:41:41 +0000
+++ debian/changelog 2015-05-16 16:30:00 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
1indicator-datetime (13.10.0+15.10.20150515-0ubuntu1) wily; urgency=medium2indicator-datetime (13.10.0+15.10.20150515-0ubuntu1) wily; urgency=medium
23
3 [ Charles Kerr ]4 [ Charles Kerr ]
@@ -90,13 +91,59 @@
90 * Add support for x-canonical-alarm and x-canonical-disabled tags in91 * Add support for x-canonical-alarm and x-canonical-disabled tags in
91 VTODO categories so that disabled alarms will not be displayed. (LP:92 VTODO categories so that disabled alarms will not be displayed. (LP:
92 #1387231)93 #1387231)
94=======
95indicator-datetime (13.10.0+15.04.20150318~rtm-0ubuntu1) 14.09; urgency=medium
96
97 [ Charles Kerr ]
98 * Work around glib's type initialization deadlock. (LP: #1425297)
99
100 -- CI Train Bot <ci-train-bot@canonical.com> Wed, 18 Mar 2015 17:28:20 +0000
101
102indicator-datetime (13.10.0+15.04.20150226~rtm-0ubuntu1) 14.09; urgency=medium
103
104 [ Charles Kerr ]
105 * Avoid ECANCELED errors in calls to timerfd_settime() (LP: #1424966)
106
107 -- CI Train Bot <ci-train-bot@canonical.com> Thu, 26 Feb 2015 05:29:29 +0000
108
109indicator-datetime (13.10.0+15.04.20150213~rtm-0ubuntu1) 14.09; urgency=medium
110
111 [ Charles Kerr ]
112 * change the WallClock to detect time changes from
113 TFD_TIMER_CANCEL_ON_SET, e.g. when ntp<-->manual is toggled
114
115 -- CI Train Bot <ci-train-bot@canonical.com> Fri, 13 Feb 2015 20:51:45 +0000
116
117indicator-datetime (13.10.0+15.04.20150122~rtm-0ubuntu1) 14.09; urgency=low
118
119 [ Charles Kerr ]
120 * Don't play calendar alarm sounds if Silent Mode is enabled. Use the
121 alarm sound role for both clock and calendar alarms. (LP: #1410874)
122
123 [ Ubuntu daily release ]
124 * New rebuild forced
125
126 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 22 Jan 2015 22:25:52 +0000
127
128indicator-datetime (13.10.0+15.04.20150115~rtm-0ubuntu1) 14.09; urgency=low
129
130 [ Charles Kerr ]
131 * Fix bug that misidentified repeating alarms as one-time alarms,
132 causing them to be disabled after triggering. (LP: #1411171)
133
134 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 15 Jan 2015 20:57:21 +0000
135
136indicator-datetime (13.10.0+15.04.20141210~rtm-0ubuntu1) 14.09; urgency=low
137
138 [ Charles Kerr ]
139>>>>>>> MERGE-SOURCE
93 * Change notifications for calendar events s.t. the sound is140 * Change notifications for calendar events s.t. the sound is
94 nonrepeating and the notification is temporary, not requiring user141 nonrepeating and the notification is temporary, not requiring user
95 interaction to disappear. (LP: #1320880)142 interaction to disappear.
96 * After a one-time Ubuntu alarm's notification is displayed, disable143 * After a one-time Ubuntu alarm's notification is displayed, disable
97 the alarm. (LP: #1362341)144 the alarm. (LP: #1362341)
98145
99 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 08 Dec 2014 23:09:20 +0000146 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 10 Dec 2014 04:16:19 +0000
100147
101indicator-datetime (13.10.0+15.04.20141103-0ubuntu1) vivid; urgency=low148indicator-datetime (13.10.0+15.04.20141103-0ubuntu1) vivid; urgency=low
102149
103150
=== modified file 'src/clock-live.cpp'
=== modified file 'src/engine-eds.cpp'
=== modified file 'src/main.cpp'
=== modified file 'src/snap.cpp'
--- src/snap.cpp 2015-04-08 23:48:24 +0000
+++ src/snap.cpp 2015-05-16 16:30:00 +0000
@@ -96,8 +96,13 @@
96 std::shared_ptr<uin::Sound> sound;96 std::shared_ptr<uin::Sound> sound;
97 if (appointment.is_ubuntu_alarm() || !silent_mode()) {97 if (appointment.is_ubuntu_alarm() || !silent_mode()) {
98 // create the sound.98 // create the sound.
99<<<<<<< TREE
99 const auto role = appointment.is_ubuntu_alarm() ? "alarm" : "alert";100 const auto role = appointment.is_ubuntu_alarm() ? "alarm" : "alert";
100 const auto uri = get_alarm_uri(alarm, m_settings);101 const auto uri = get_alarm_uri(alarm, m_settings);
102=======
103 const auto role = appointment.is_ubuntu_alarm() ? "alarm" : "alert";
104 const auto uri = get_alarm_uri(appointment, m_settings);
105>>>>>>> MERGE-SOURCE
101 const auto volume = m_settings->alarm_volume.get();106 const auto volume = m_settings->alarm_volume.get();
102 const bool loop = interactive;107 const bool loop = interactive;
103 sound = std::make_shared<uin::Sound>(role, uri, volume, loop);108 sound = std::make_shared<uin::Sound>(role, uri, volume, loop);
@@ -139,6 +144,10 @@
139 b.add_action ("ok", _("OK"));144 b.add_action ("ok", _("OK"));
140 b.add_action ("snooze", _("Snooze"));145 b.add_action ("snooze", _("Snooze"));
141 }146 }
147 // Show calendar notification in notification area
148 else {
149 b.add_hint (uin::Builder::HINT_SNAP);
150 }
142151
143 // add 'sound', 'haptic', and 'awake' objects to the capture so152 // add 'sound', 'haptic', and 'awake' objects to the capture so
144 // they stay alive until the closed callback is called; i.e.,153 // they stay alive until the closed callback is called; i.e.,
145154
=== modified file 'src/wakeup-timer-powerd.cpp'
--- src/wakeup-timer-powerd.cpp 2014-11-04 18:27:27 +0000
+++ src/wakeup-timer-powerd.cpp 2015-05-16 16:30:00 +0000
@@ -192,13 +192,8 @@
192 ret = g_dbus_connection_call_finish(G_DBUS_CONNECTION(o), res, &error);192 ret = g_dbus_connection_call_finish(G_DBUS_CONNECTION(o), res, &error);
193 if (ret == nullptr)193 if (ret == nullptr)
194 {194 {
195 /* powerd isn't on the desktop, but we don't need hardware wakeups there195 if (!g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
196 anyway... so no need to warn on SERVICE_UNKNOWN */
197 if (!g_error_matches(error, G_IO_ERROR, G_IO_ERROR_CANCELLED) &&
198 !g_error_matches(error, G_DBUS_ERROR, G_DBUS_ERROR_SERVICE_UNKNOWN))
199 {
200 g_warning("%s Could not set hardware wakeup: %s", G_STRLOC, error->message);196 g_warning("%s Could not set hardware wakeup: %s", G_STRLOC, error->message);
201 }
202 }197 }
203 else198 else
204 {199 {

Subscribers

People subscribed via source and target branches