Merge lp:~mandel/location-service/verbose-logging into lp:location-service/trunk

[Manuel de la Peña]

Add extra needed logging.

Add extra logging to help with future bugs.

[Jim Hodapp (jhodapp)]

Looks good

review: Approve (code)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:193
http://jenkins.qa.ubuntu.com/job/location-service-ci/373/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/location-service-vivid-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/location-service-vivid-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/location-service-vivid-armhf-ci/45/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/location-service-vivid-i386-ci/45/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/location-service-ci/373/rebuild

review: Needs Fixing (continuous-integration)

[Thomas Voß (thomas-voss)]

A few comments inline.

review: Needs Fixing

[lp:~mandel/location-service/verbose-logging]

194. By Manuel de la Peña on 2015-04-29

Small changes after reviews.

195. By Manuel de la Peña on 2015-04-29

Made changes according to reviews.

196. By Manuel de la Peña on 2015-05-26

Merged first-connection into verbose-logging.

Unmerged revisions

196. By Manuel de la Peña on 2015-05-26

Merged first-connection into verbose-logging.

195. By Manuel de la Peña on 2015-04-29

Made changes according to reviews.

194. By Manuel de la Peña on 2015-04-29

Small changes after reviews.

193. By Manuel de la Peña on 2015-04-27

Merged first-connection into verbose-logging.

192. By Manuel de la Peña on 2015-04-27

Increased logging.

=== modified file 'src/location_service/com/ubuntu/location/connectivity/ofono_nm_connectivity_manager.cpp'
--- src/location_service/com/ubuntu/location/connectivity/ofono_nm_connectivity_manager.cpp	2015-04-27 15:44:40 +0000
+++ src/location_service/com/ubuntu/location/connectivity/ofono_nm_connectivity_manager.cpp	2015-05-26 16:07:15 +0000
@@ -230,7 +230,7 @@
 
 void connectivity::OfonoNmConnectivityManager::Private::on_modem_added(const core::dbus::types::ObjectPath& path)
 {
-    VLOG(1) << __PRETTY_FUNCTION__;
+    VLOG(1) << __PRETTY_FUNCTION__ << " mode: " << path;
 
     auto modem = modem_manager->modem_for_path(path);
 
@@ -298,7 +298,7 @@
 
 void connectivity::OfonoNmConnectivityManager::Private::on_modem_removed(const core::dbus::types::ObjectPath& path)
 {
-    VLOG(1) << __PRETTY_FUNCTION__;
+    VLOG(1) << __PRETTY_FUNCTION__ << " modem:" << path;
 
     detail::CachedRadioCell::Ptr cell;
     {
@@ -765,6 +765,10 @@
 
         return instance;
     }
+    catch (const std::exception& e)
+    {
+        LOG(WARNING) << e.what();
+    }
     catch(...)
     {
     }
 
=== modified file 'src/location_service/com/ubuntu/location/non_selecting_provider_selection_policy.cpp'
--- src/location_service/com/ubuntu/location/non_selecting_provider_selection_policy.cpp	2015-04-23 14:48:44 +0000
+++ src/location_service/com/ubuntu/location/non_selecting_provider_selection_policy.cpp	2015-05-26 16:07:15 +0000
@@ -14,8 +14,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
  * Authored by: Thomas Voß <[e-mail]>
+ *              Manuel de la Pena <[e-mail]>
  */
 
+#include <com/ubuntu/location/logging.h>
 #include <com/ubuntu/location/non_selecting_provider_selection_policy.h>
 
 #include <set>
@@ -53,16 +55,19 @@
         {
             connections.push_back(provider->updates().position.connect([this](const location::Update<location::Position>& update)
             {
+                VLOG(10) << "Received positon update " << update;
                 mutable_updates().position(update);
             }));
 
             connections.push_back(provider->updates().heading.connect([this](const location::Update<location::Heading>& update)
             {
+                VLOG(10) << "Received heading update " << update;
                 mutable_updates().heading(update);
             }));
 
             connections.push_back(provider->updates().velocity.connect([this](const location::Update<location::Velocity>& update)
             {
+                VLOG(10) << "Received velocity update " << update;
                 mutable_updates().velocity(update);
             }));
         }
 
=== modified file 'src/location_service/com/ubuntu/location/service/daemon.cpp'
--- src/location_service/com/ubuntu/location/service/daemon.cpp	2015-04-16 10:03:29 +0000
+++ src/location_service/com/ubuntu/location/service/daemon.cpp	2015-05-26 16:07:15 +0000
@@ -195,7 +195,8 @@
             else
                 throw std::runtime_error("Problem instantiating provider");
 
-        } catch(const std::runtime_error& e)
+        }
+        catch(const std::runtime_error& e)
         {
             std::cerr << "Issue instantiating provider: " << e.what() << std::endl;
         }