Merge lp:~madsa/slingshot/fix-app-focus into lp:~elementary-pantheon/slingshot/trunk

Proposed by Matt Spaulding
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp:~madsa/slingshot/fix-app-focus
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 23 lines (+2/-4)
1 file modified
lib/synapse-core/common-actions.vala (+2/-4)
To merge this branch: bzr merge lp:~madsa/slingshot/fix-app-focus
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+307382@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

This doesn't fix the problem for me, I used Calculator as a test and the behavior is unchanged. It starts focused, then goes unfocused.

Revision history for this message
Matt Spaulding (madsa) wrote :

I didn't test with Calculator, but for me when I run Calculator it is focused with or without the patch. I don't seem to have a problem with that one. And I'll also note that the loss of focus only happens when another window is already open.

The two apps I really see a problem with are Terminal and AppCenter. The other apps I've tried now don't seem to have the focus problem. You might try testing with those two.

Revision history for this message
Zisu Andrei (matzipan) wrote :

Rejecting since it did not fix the issue for Cody.

Unmerged revisions

696. By Matt Spaulding

Fix app focus when opening from search

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/synapse-core/common-actions.vala'
--- lib/synapse-core/common-actions.vala 2014-06-04 19:35:44 +0000
+++ lib/synapse-core/common-actions.vala 2016-10-02 05:17:22 +0000
@@ -93,8 +93,7 @@
9393
94 try94 try
95 {95 {
96 var display = Gdk.Display.get_default ();96 app.launch (null, null);
97 app.launch (null, display.get_app_launch_context ());
98 97
99 RelevancyService.get_default ().application_launched (app);98 RelevancyService.get_default ().application_launched (app);
100 }99 }
@@ -152,8 +151,7 @@
152 AppInfo app = AppInfo.create_from_commandline (151 AppInfo app = AppInfo.create_from_commandline (
153 original.get_commandline (), original.get_name (),152 original.get_commandline (), original.get_name (),
154 AppInfoCreateFlags.NEEDS_TERMINAL);153 AppInfoCreateFlags.NEEDS_TERMINAL);
155 var display = Gdk.Display.get_default ();154 app.launch (null, null);
156 app.launch (null, display.get_app_launch_context ());
157 }155 }
158 catch (Error err)156 catch (Error err)
159 {157 {

Subscribers

People subscribed via source and target branches