Merge lp:~mabac/launchpad-work-items-tracker/support-deferred-cards into lp:~linaro-automation/launchpad-work-items-tracker/linaro
Proposed by
Mattias Backman
Status: | Merged |
---|---|
Merged at revision: | 322 |
Proposed branch: | lp:~mabac/launchpad-work-items-tracker/support-deferred-cards |
Merge into: | lp:~linaro-automation/launchpad-work-items-tracker/linaro |
Diff against target: |
110 lines (+44/-34) 2 files modified
collect_roadmap (+40/-34) lpworkitems/collect_roadmap.py (+4/-0) |
To merge this branch: | bzr merge lp:~mabac/launchpad-work-items-tracker/support-deferred-cards |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email: mp+86405@code.launchpad.net |
Description of the change
Hi,
This branch adds support for collecting the Deferred lane.
It does this by accepting that there are Cards without status (sub lanes) and only collects cards for Lanes which have been collected. The last part is because of the Legend lane which also have no sub lanes, but we actually ignore that lane before cards are collected.
Thanks,
Mattias
To post a comment you must log in.
Looks good to me: to confirm my understanding, this basically only replaces use of 'task_status is None' when checking if a card needs to be collected by using either task_status[ 'parent_ id'] or task['task' ]['workflow_ stage_id' ] to check if a lane by that ID is collected instead using the new method lane_is_collected. All the rest is reindentation, afaics, so good to go.
(and oh my, this code does miss tests :)