Merge lp:~lukas-baubkus/owncloud-sync/feature-keep-serverUrl-port-for-webdav into lp:owncloud-sync/ubsync

[Luksus]

fix removing of cloud-server-portnumber, while creating the webdav access-url-path.

Fixes: Bug #1815388, and perhaps Bug #1592782

Retrieves the portnumber if one exists and makes use of the port parameter in QWebdav::setConnectionSettings.

[slash (slash-tux)]

Thanks, I'll try to create a test version, would you be able to test it ?

[Luksus (lukas-baubkus)]

> Thanks, I'll try to create a test version, would you be able to test it ?

Sure.

[slash (slash-tux)]

Hello Luksus,
Sorry for the delay.
I was able to manage to find back a virtual machine to compile ubsync, with some changes, yours included.
I've let the full debug for you to troubleshoot...
https://www.dropfile.nl/f/Jbt63

- Are you on Ubports telegram supergroup ?
- Are you good in compiling ? I would like to move ubsync out of QT creator ubuntu 16.04 to clickable. But so far all trial failed.

[Luksus (lukas-baubkus)]

Hi, sorry for the late response, I was on vacation the last days.
I am currently a little bit confused. Somehow, the UBsync version on my phone already has the fix and I don't know anymore, how it got there... ;-)

Ok, I will have a look into it.

Honestly I am not very familiar with compiling that qml/c++ stuff, but as I already was digging around with a lot of ubports apps and clickable, maybe I am able to solve that problem.

Yes I am in the telegram supergroup, just as "Lukas".

[Luksus (lukas-baubkus)]

The click-package installs and works flawless.

I managed to build the project with clickable.

Just changed the line in OwncloudSync.pro:
LIBS += -L$$OUT_PWD/../qwebdavlib/ -lqwebdav
to
LIBS += -L$$OUT_PWD/../qwebdavlib

I am not sure what this -lqwebdav string is supposed to do, perhaps it is a temporary library-title for the built qwebdavlib. It seems, that it is not needed. At least I could not find any references to "lqwebdav" in the code or other files.

with "clickable clean build click-build" a click-package gets created.

But the share-directory, with language files is missing. I am not sure how this gets created.

[slash (slash-tux)]

Thank you !

review: Approve

=== modified file 'OwncloudSync/webdavfolderlistmodel.cpp'
--- OwncloudSync/webdavfolderlistmodel.cpp	2018-08-09 03:52:33 +0000
+++ OwncloudSync/webdavfolderlistmodel.cpp	2019-02-12 09:07:47 +0000
@@ -53,6 +53,10 @@
         QString url = sUrl.host();
         qDebug() << "webdav::setConnectionSettings" << "url:" << url;
 
+        int port = sUrl.port();
+        if(port == -1) port = 0;
+        qDebug() << "webdav::setConnectionSettings" << "port:" << port;
+
         QString path = sUrl.path();
         path.append("/remote.php/webdav/");
         qDebug() << "webdav::setConnectionSettings" << "path:" << path;
@@ -66,7 +70,7 @@
             connectionType = QWebdav::HTTP;
         }
 
-        m_webdav.setConnectionSettings(connectionType, url, path, m_username, m_password);
+        m_webdav.setConnectionSettings(connectionType, url, path, m_username, m_password, port);
 
     }
 }