Merge ~lucaskanashiro/ubuntu/+source/openvpn:drop-reload into ubuntu/+source/openvpn:ubuntu/devel
Status: | Merged |
---|---|
Approved by: | Lucas Kanashiro |
Approved revision: | 3ce84bbf5301e107683a57ca53a186c37d24b8fb |
Merged at revision: | 3ce84bbf5301e107683a57ca53a186c37d24b8fb |
Proposed branch: | ~lucaskanashiro/ubuntu/+source/openvpn:drop-reload |
Merge into: | ubuntu/+source/openvpn:ubuntu/devel |
Diff against target: |
46 lines (+6/-3) 3 files modified
debian/changelog (+6/-0) debian/openvpn.service (+0/-1) debian/openvpn@.service (+0/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+384585@code.launchpad.net |
Description of the change
This MP aims to fix this bug in Groovy:
https:/
Currently, the ExecReload= tries to send a SIGHUP signal to the process but it does not have the permission to do this. It'd need a new capability (CAP_KILL) or a + prefix to run this command with full privileges. However, after trying the mentioned solutions I noticed that actually the SIGHUP signal handling implementation does something similar to the restart process, not justifying the existence of the reload implementation. Moreover, systemd does not require a reload implementation, so I believe dropping this systemd reload support is the way to go.
I submitted these changes to Debian here:
https:/
autopkgtest is happy:
autopkgtest [16:59:57]: @@@@@@@
server-
server-
And here is my PPA with the proposed package:
https:/
Hey, the rationale makes sense to me, and I agree with the proposed solution.
I can't help but wonder why we (and Debian) are carrying our own version of the systemd service file, instead of relying on what upstream provides (and patching/adjusting it, if needed). I tried doing some archaeology on the Debian repo, but could not find the reason for it. Maybe something to keep in mind for a next merge (or a rainy day)...