Merge lp:lubuntu-software-center/stable into lp:lubuntu-software-center

Proposed by MiKRo.MiCsoftware.Com
Status: Needs review
Proposed branch: lp:lubuntu-software-center/stable
Merge into: lp:lubuntu-software-center
Diff against target: 84 lines (+29/-3) (has conflicts)
2 files modified
Makefile.am (+1/-3)
src/main.py (+28/-0)
Text conflict in src/main.py
To merge this branch: bzr merge lp:lubuntu-software-center/stable
Reviewer Review Type Date Requested Status
ԜаӀtеr Ⅼарсһуnѕkі Disapprove
Review via email: mp+373707@code.launchpad.net
To post a comment you must log in.
Revision history for this message
ԜаӀtеr Ⅼарсһуnѕkі (wxl) wrote :

As the project has been abandoned by its developers and dropped by Lubuntu, I see no value to this at all. Furthermore, the only version in the Ubuntu archives is in Xenial which is unsupported by Lubuntu as well as every other flavor.

review: Disapprove

Unmerged revisions

124. By Stephen Smally

refixed build

123. By Stephen Smally

fixed build

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2015-02-22 02:43:13 +0000
+++ Makefile.am 2019-10-06 04:37:36 +0000
@@ -39,9 +39,7 @@
3939
40lscdatadir = $(datadir)/LSC40lscdatadir = $(datadir)/LSC
41lscdata_DATA = \41lscdata_DATA = \
42 data/categories.ini \42 data/categories.ini
43 data/lsc.ui \
44 data/preferences.ui
4543
46icon16dir = $(datadir)/icons/hicolor/16x16/apps44icon16dir = $(datadir)/icons/hicolor/16x16/apps
47icon16_DATA = data/icons/16x16/light-software-center.png45icon16_DATA = data/icons/16x16/light-software-center.png
4846
=== modified file 'src/main.py'
--- src/main.py 2015-12-28 22:26:36 +0000
+++ src/main.py 2019-10-06 04:37:36 +0000
@@ -581,6 +581,7 @@
581 else:581 else:
582 inst = False582 inst = False
583 self.setup_infos(583 self.setup_infos(
584<<<<<<< TREE
584 self.pkg_selected[0],585 self.pkg_selected[0],
585 self.ui.pages,586 self.ui.pages,
586 self.pkg_selected[2],587 self.pkg_selected[2],
@@ -593,6 +594,18 @@
593 self.candidate.ver_str,594 self.candidate.ver_str,
594 self.ui.pages.get_current_page(),595 self.ui.pages.get_current_page(),
595 inst596 inst
597=======
598 self.pkg_selected[0],
599 self.ui.pages,
600 self.pkg_selected[2],
601 u"\n".join([self.pkg_selected[1].split("\n")[0], threadingops.getshortdesc(self.pkg_selected[0])]),
602 threadingops.getdesc(self.pkg_selected[0]).replace("\n ", "\n"),
603 (apt_pkg.size_to_str(self.candidate.size),
604 apt_pkg.size_to_str(self.candidate.installed_size)),
605 self.candidate.ver_str,
606 self.ui.pages.get_current_page(),
607 inst
608>>>>>>> MERGE-SOURCE
596 )609 )
597610
598 def app_item_activated(self, widget, path, column, inst_rem):611 def app_item_activated(self, widget, path, column, inst_rem):
@@ -674,6 +687,7 @@
674 description_formatted = description_formatted.replace(687 description_formatted = description_formatted.replace(
675 title.split("\n")[-1], "")688 title.split("\n")[-1], "")
676 self.ui.appsinfo.desctext.set_text(description_formatted.strip())689 self.ui.appsinfo.desctext.set_text(description_formatted.strip())
690<<<<<<< TREE
677 self.ui.appsinfo.details.to_download.set_markup(691 self.ui.appsinfo.details.to_download.set_markup(
678 "<b>" + _("Download Size:") + "</b>" + " %s" % size[0])692 "<b>" + _("Download Size:") + "</b>" + " %s" % size[0])
679 self.ui.appsinfo.details.installed.set_markup(693 self.ui.appsinfo.details.installed.set_markup(
@@ -684,6 +698,13 @@
684 "stock_help", Gtk.IconSize.LARGE_TOOLBAR)698 "stock_help", Gtk.IconSize.LARGE_TOOLBAR)
685 self.ui.categorie_label.set_text(_(699 self.ui.categorie_label.set_text(_(
686 "Info on") + " %s" % title.split("\n")[0])700 "Info on") + " %s" % title.split("\n")[0])
701=======
702 self.ui.appsinfo.details.to_download.set_markup("<b>"+_("Download Size:")+"</b>"+" %s" % size[0])
703 self.ui.appsinfo.details.installed.set_markup("<b>"+_("Installed Size:")+"</b>"+" %s" % size[1])
704 self.ui.appsinfo.details.version.set_markup("<b>"+_("Version:")+"</b>"+" %s (%s)" % (version, name))
705 self.ui.categorie_icon.set_from_icon_name("stock_help", Gtk.IconSize.LARGE_TOOLBAR)
706 self.ui.categorie_label.set_text(_("Infos about")+u" %s" % title.split("\n")[0])
707>>>>>>> MERGE-SOURCE
687 self.ui.appsinfo.scrot_button.set_visible(False)708 self.ui.appsinfo.scrot_button.set_visible(False)
688 if control.controller.show_scrot:709 if control.controller.show_scrot:
689 threadingops.download_screenshot(710 threadingops.download_screenshot(
@@ -773,9 +794,16 @@
773 status_dict[self.pkg_in_cache.current_state],794 status_dict[self.pkg_in_cache.current_state],
774 ]795 ]
775 model.append(self.item)796 model.append(self.item)
797<<<<<<< TREE
776 self.ui.progressbar.set_fraction(float(cur) / float(tot))798 self.ui.progressbar.set_fraction(float(cur) / float(tot))
777 except KeyError:799 except KeyError:
778 pass800 pass
801=======
802 self.ui.progressbar.set_fraction(float(cur)/float(tot))
803 while Gtk.events_pending():
804 Gtk.main_iteration()
805 except KeyError: pass
806>>>>>>> MERGE-SOURCE
779807
780808
781def lscmain():809def lscmain():

Subscribers

People subscribed via source and target branches