Merge lp:~ltrager/maas/fix_exception into lp:~maas-committers/maas/trunk
Proposed by
Lee Trager
Status: | Merged |
---|---|
Approved by: | Lee Trager |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5015 |
Proposed branch: | lp:~ltrager/maas/fix_exception |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
288 lines (+71/-73) 6 files modified
src/maasserver/api/devices.py (+1/-1) src/maasserver/api/machines.py (+14/-1) src/maasserver/api/tests/test_devices.py (+1/-1) src/maasserver/api/tests/test_machine.py (+50/-13) src/maasserver/models/node.py (+3/-20) src/maasserver/models/tests/test_node.py (+2/-37) |
To merge this branch: | bzr merge lp:~ltrager/maas/fix_exception |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Approve | ||
Blake Rouse (community) | Approve | ||
Review via email: mp+294421@code.launchpad.net |
Commit message
In restore methods use assert on the model and raise NodeStateViolation on the API
Description of the change
As per the discussion in the stand up this turns the validation in set_initial_
To post a comment you must log in.
Looks good. Need to fix one of the API validation messages and add a message to the assert as well.