Merge lp:~lore-mattei/onehundredscopes/flickr-precise into lp:~davidc3/onehundredscopes/flickr

Proposed by Lorenzo Mattei
Status: Merged
Merged at revision: 10
Proposed branch: lp:~lore-mattei/onehundredscopes/flickr-precise
Merge into: lp:~davidc3/onehundredscopes/flickr
Diff against target: 106 lines (+32/-22)
2 files modified
debian/control (+2/-2)
src/unity-scope-flickr (+30/-20)
To merge this branch: bzr merge lp:~lore-mattei/onehundredscopes/flickr-precise
Reviewer Review Type Date Requested Status
David Callé Approve
Review via email: mp+95182@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Callé (davidc3) wrote :

I'm merging it with a few changes. Have a look at the final diff.

review: Approve
10. By David Callé

Port to Precise. Thanks Lorenzo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2012-01-08 15:33:20 +0000
+++ debian/control 2012-02-29 14:38:19 +0000
@@ -17,8 +17,8 @@
17Depends: ${shlibs:Depends},17Depends: ${shlibs:Depends},
18 ${misc:Depends},18 ${misc:Depends},
19 ${python:Depends},19 ${python:Depends},
20 gir1.2-unity-4.0,20 gir1.2-unity-5.0,
21 gir1.2-dee-0.5,21 gir1.2-dee-1.0,
22 python-flickrapi,22 python-flickrapi,
23 unity-lens-photo,23 unity-lens-photo,
24Enhances: unity-lens-photo24Enhances: unity-lens-photo
2525
=== modified file 'src/unity-scope-flickr'
--- src/unity-scope-flickr 2012-01-07 20:07:47 +0000
+++ src/unity-scope-flickr 2012-02-29 14:38:19 +0000
@@ -43,10 +43,10 @@
43 def __init__ (self):43 def __init__ (self):
44 self.scope = Unity.Scope.new ("/net/launchpad/scope/image/flickr")44 self.scope = Unity.Scope.new ("/net/launchpad/scope/image/flickr")
45 self.scope.search_in_global = False45 self.scope.search_in_global = False
46 self.scope.connect ("notify::active-search", self.on_search_changed)46 self.scope.connect ("search-changed", self.on_search_changed)
47 self.scope.connect ("filters-changed", self.on_search_changed);47 self.scope.connect ("filters-changed", self.on_search_changed)
48# self.scope.connect ("notify::active", self.on_search_changed);
49 self.scope.connect ("activate-uri", self.on_activate_uri);48 self.scope.connect ("activate-uri", self.on_activate_uri);
49 self.scope.connect("notify::active", self.on_lens_active)
50 self.scope.export()50 self.scope.export()
5151
52 def on_activate_uri (self, scope, uri):52 def on_activate_uri (self, scope, uri):
@@ -71,30 +71,42 @@
71 (token, frob) = flickr.get_token_part_one(perms='write')71 (token, frob) = flickr.get_token_part_one(perms='write')
72 global clicked72 global clicked
73 clicked = True73 clicked = True
7474
75 def get_search_string (self):75 def on_lens_active(self, *_):
76 search = self.scope.props.active_search76 """ Run a search when the lens is opened """
77 return search.props.search_string if search else None77 if self.scope.props.active:
7878 self.scope.queue_search_changed(Unity.SearchType.DEFAULT)
79 def on_search_changed (self, scope, param_spec=None):79
80 search = self.get_search_string()80 def on_search_changed (self, scope, search, search_type, _):
81 print "Search changed to: '%s'" % search81 search_string = search.props.search_string.strip()
82 results = self.scope.props.results_model82 model = search.props.results_model
83 results.clear()83 model.clear()
84 print "Search changed to: '%s'" % search_string
85
84 if flickr.token_cache.token:86 if flickr.token_cache.token:
85 has_token = True87 has_token = True
86 else:88 else:
87 has_token = False89 has_token = False
88 if clicked:90 if clicked:
89 flickr.get_token_part_two((token, frob))91 flickr.get_token_part_two((token, frob))
90 self.update_results_model (search, results, '1', has_token)92 if search_type is Unity.SearchType.DEFAULT:
91 results.flush_revision_queue ()93 if search_string == '':
94 print "Global view without search string : hide"
95 else:
96 self.update_results_model(search_string, model, '1', has_token)
97 if search:
98 search.finished()
9299
93 def update_results_model(self, search, model, page, has_token):100 def update_results_model(self, search, model, page, has_token):
94 i = ''101 i = ''
95 counter = 0102 counter = 0
103 cat = 0
104 if len(search) > 0:
105 cat = 2
106 else:
107 cat = 0
96 if not has_token:108 if not has_token:
97 model.append ("connect", "goa-panel", 2,"text/html", "Authorize with Flickr", '', '')109 model.append ("connect", "goa-panel", cat,"text/html", "Authorize with Flickr", '', '')
98 else:110 else:
99 taken_by = self.check_filters("taken_by")111 taken_by = self.check_filters("taken_by")
100 date = self.check_filters("date")112 date = self.check_filters("date")
@@ -104,15 +116,13 @@
104 comment = i[1]116 comment = i[1]
105 uri = i[2]117 uri = i[2]
106 icon_hint = i[3]118 icon_hint = i[3]
107 model.append (uri, icon_hint, 2,"text/html", title, comment, uri)119 model.append (uri, icon_hint, cat,"text/html", title, comment, uri)
108 if i and counter > 49:120 if i and counter > 49:
109 if not search:121 if not search:
110 search = ''122 search = ''
111 page = int(page)+1123 page = int(page)+1
112 model.append ("more__"+search+"__"+str(page), "add", 2,"text/html", "More results", '', '')124 model.append ("more__"+search+"__"+str(page), "add", cat,"text/html", "More results", '', '')
113125
114 if self.scope.props.active_search:
115 self.scope.props.active_search.emit("finished")
116126
117 def check_filters(self, filter_name):127 def check_filters(self, filter_name):
118 try:128 try:

Subscribers

People subscribed via source and target branches

to all changes: