Merge lp:~linuxjedi/libdrizzle/5.1-compiler-fixes into lp:libdrizzle

Proposed by Andrew Hutchings
Status: Merged
Approved by: Andrew Hutchings
Approved revision: no longer in the source branch.
Merged at revision: 122
Proposed branch: lp:~linuxjedi/libdrizzle/5.1-compiler-fixes
Merge into: lp:libdrizzle
Diff against target: 34 lines (+3/-3)
2 files modified
libdrizzle/sha1.cc (+1/-1)
m4/ax_harden_compiler_flags.m4 (+2/-2)
To merge this branch: bzr merge lp:~linuxjedi/libdrizzle/5.1-compiler-fixes
Reviewer Review Type Date Requested Status
Drizzle Trunk Pending
Review via email: mp+161365@code.launchpad.net

Description of the change

Adds a suppression for the SHA1 code and reverts the earlier hacky fix I made

To post a comment you must log in.
122. By Drizzle Continuous Integration

Merge lp:~linuxjedi/libdrizzle/5.1-compiler-fixes Build: jenkins-Libdrizzle-102

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libdrizzle/sha1.cc'
--- libdrizzle/sha1.cc 2013-04-28 18:27:40 +0000
+++ libdrizzle/sha1.cc 2013-04-29 06:15:31 +0000
@@ -128,7 +128,7 @@
128void128void
129SHA1Update(SHA1_CTX *context, const uint8_t *data, size_t len)129SHA1Update(SHA1_CTX *context, const uint8_t *data, size_t len)
130{130{
131 uint32_t i, j;131 size_t i, j;
132132
133 j = (size_t)((context->count >> 3) & 63);133 j = (size_t)((context->count >> 3) & 63);
134 context->count += (len << 3);134 context->count += (len << 3);
135135
=== modified file 'm4/ax_harden_compiler_flags.m4'
--- m4/ax_harden_compiler_flags.m4 2013-04-28 18:27:40 +0000
+++ m4/ax_harden_compiler_flags.m4 2013-04-29 06:15:31 +0000
@@ -155,7 +155,7 @@
155 _APPEND_COMPILE_FLAGS_ERROR([-Wswitch-enum])155 _APPEND_COMPILE_FLAGS_ERROR([-Wswitch-enum])
156 _APPEND_COMPILE_FLAGS_ERROR([-Wtrampolines])156 _APPEND_COMPILE_FLAGS_ERROR([-Wtrampolines])
157 _APPEND_COMPILE_FLAGS_ERROR([-Wundef])157 _APPEND_COMPILE_FLAGS_ERROR([-Wundef])
158 _APPEND_COMPILE_FLAGS_ERROR([-Wunsafe-loop-optimizations])158# _APPEND_COMPILE_FLAGS_ERROR([-Wunsafe-loop-optimizations])
159 _APPEND_COMPILE_FLAGS_ERROR([-funsafe-loop-optimizations])159 _APPEND_COMPILE_FLAGS_ERROR([-funsafe-loop-optimizations])
160 AS_IF([test "x$ac_cv_vcs_checkout" = xyes && test "x$MINGW" != xyes],[160 AS_IF([test "x$ac_cv_vcs_checkout" = xyes && test "x$MINGW" != xyes],[
161 _APPEND_COMPILE_FLAGS_ERROR([-fno-omit-frame-pointer])161 _APPEND_COMPILE_FLAGS_ERROR([-fno-omit-frame-pointer])
@@ -275,7 +275,7 @@
275 _APPEND_COMPILE_FLAGS_ERROR([-Wswitch-enum])275 _APPEND_COMPILE_FLAGS_ERROR([-Wswitch-enum])
276 _APPEND_COMPILE_FLAGS_ERROR([-Wtrampolines])276 _APPEND_COMPILE_FLAGS_ERROR([-Wtrampolines])
277 _APPEND_COMPILE_FLAGS_ERROR([-Wundef])277 _APPEND_COMPILE_FLAGS_ERROR([-Wundef])
278 _APPEND_COMPILE_FLAGS_ERROR([-Wunsafe-loop-optimizations])278# _APPEND_COMPILE_FLAGS_ERROR([-Wunsafe-loop-optimizations])
279 _APPEND_COMPILE_FLAGS_ERROR([-funsafe-loop-optimizations])279 _APPEND_COMPILE_FLAGS_ERROR([-funsafe-loop-optimizations])
280 _APPEND_COMPILE_FLAGS_ERROR([-Wc++11-compat])280 _APPEND_COMPILE_FLAGS_ERROR([-Wc++11-compat])
281# _APPEND_COMPILE_FLAGS_ERROR([-Weffc++])281# _APPEND_COMPILE_FLAGS_ERROR([-Weffc++])

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: