Merge lp:~lifeless/launchpad/bug-627701 into lp:launchpad
Proposed by
Robert Collins
Status: | Merged |
---|---|
Approved by: | Jonathan Lange |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11668 |
Proposed branch: | lp:~lifeless/launchpad/bug-627701 |
Merge into: | lp:launchpad |
Diff against target: |
285 lines (+125/-20) 5 files modified
lib/canonical/launchpad/doc/timeout.txt (+38/-5) lib/canonical/launchpad/webapp/adapter.py (+48/-10) lib/canonical/launchpad/webapp/ftests/test_adapter.py (+19/-1) lib/canonical/launchpad/webapp/publication.py (+17/-0) lib/lp/services/features/flags.py (+3/-4) |
To merge this branch: | bzr merge lp:~lifeless/launchpad/bug-627701 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Lange (community) | Approve | ||
Review via email: mp+37094@code.launchpad.net |
Commit message
Permit controlling timeouts via feature flags.
Description of the change
Permit controlling timeouts via feature flags - a collaboration between Diogo and I.
To post a comment you must log in.
* Line 137 of the diff. If getFeatureFlag raises, then timeout_str is never set and the "if timeout_str" check will fail with a NameError. This leads me to believe the code was not TDDd.
* The documentation in timeout.txt doesn't make it clear how you would use this feature flag for the purposes stated in the text (e.g. pages for which there are a few specific users). As far as I can tell from the test, it's a global thing. It would be nice to point to some place the reader could learn more.