Merge lp:~leonardolemos/cerbere/bump-years into lp:~elementary-pantheon/cerbere/cerbere

Proposed by Leonardo Lemos
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp:~leonardolemos/cerbere/bump-years
Merge into: lp:~elementary-pantheon/cerbere/cerbere
Diff against target: 108 lines (+11/-11)
5 files modified
src/Cerbere.vala (+2/-2)
src/ProcessWrapper.vala (+1/-1)
src/SessionManager.vala (+1/-1)
src/SettingsManager.vala (+1/-1)
src/Watchdog.vala (+6/-6)
To merge this branch: bzr merge lp:~leonardolemos/cerbere/bump-years
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+313947@code.launchpad.net

Commit message

Add 2017 to license copyright and app years.

Description of the change

Add 2017 to license copyright and app years.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

I don't think you should bump copyright years for inactive individuals.

review: Disapprove

Unmerged revisions

53. By Leonardo Lemos

Bump app and copyright years

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Cerbere.vala'
--- src/Cerbere.vala 2013-05-03 04:52:31 +0000
+++ src/Cerbere.vala 2017-01-01 22:10:39 +0000
@@ -3,7 +3,7 @@
3 * Cerbere.vala3 * Cerbere.vala
4 * This file is part of cerbere, a watchdog for the Pantheon Desktop4 * This file is part of cerbere, a watchdog for the Pantheon Desktop
5 *5 *
6 * Copyright (C) 2011-2012 - Allen Lowe6 * Copyright (C) 2011-2017 - Allen Lowe
7 *7 *
8 * Cerbere is free software; you can redistribute it and/or modify8 * Cerbere is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by9 * it under the terms of the GNU General Public License as published by
@@ -74,7 +74,7 @@
74 private void start_processes (string[] process_list) {74 private void start_processes (string[] process_list) {
75 if (watchdog == null)75 if (watchdog == null)
76 watchdog = new Watchdog ();76 watchdog = new Watchdog ();
77 77
78 foreach (string cmd in process_list)78 foreach (string cmd in process_list)
79 watchdog.add_process (cmd);79 watchdog.add_process (cmd);
80 }80 }
8181
=== modified file 'src/ProcessWrapper.vala'
--- src/ProcessWrapper.vala 2012-11-22 23:12:01 +0000
+++ src/ProcessWrapper.vala 2017-01-01 22:10:39 +0000
@@ -1,6 +1,6 @@
1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */
2/*2/*
3 * Copyright (C) 2012 Victor Eduardo <victoreduardm@gmail.com>3 * Copyright (C) 2012-2017 Victor Eduardo <victoreduardm@gmail.com>
4 *4 *
5 * Cerbere is free software; you can redistribute it and/or modify5 * Cerbere is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by6 * it under the terms of the GNU General Public License as published by
77
=== modified file 'src/SessionManager.vala'
--- src/SessionManager.vala 2013-04-19 04:09:47 +0000
+++ src/SessionManager.vala 2017-01-01 22:10:39 +0000
@@ -1,6 +1,6 @@
1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */
2/*2/*
3 * Copyright (C) 2012 Victor Eduardo <victoreduardm@gmail.com>3 * Copyright (C) 2012-2017 Victor Eduardo <victoreduardm@gmail.com>
4 *4 *
5 * Cerbere is free software; you can redistribute it and/or modify5 * Cerbere is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by6 * it under the terms of the GNU General Public License as published by
77
=== modified file 'src/SettingsManager.vala'
--- src/SettingsManager.vala 2015-04-21 17:37:04 +0000
+++ src/SettingsManager.vala 2017-01-01 22:10:39 +0000
@@ -1,6 +1,6 @@
1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */1/* -*- Mode: vala; indent-tabs-mode: nil; tab-width: 4 -*- */
2/*2/*
3 * Copyright (C) 2012 Victor Eduardo <victoreduardm@gmail.com>3 * Copyright (C) 2012-2017 Victor Eduardo <victoreduardm@gmail.com>
4 *4 *
5 * Cerbere is free software; you can redistribute it and/or modify5 * Cerbere is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by6 * it under the terms of the GNU General Public License as published by
77
=== modified file 'src/Watchdog.vala'
--- src/Watchdog.vala 2013-11-09 18:17:23 +0000
+++ src/Watchdog.vala 2017-01-01 22:10:39 +0000
@@ -3,7 +3,7 @@
3 * Watchdog.vala3 * Watchdog.vala
4 * This file is part of cerbere, a watchdog for the Pantheon Desktop4 * This file is part of cerbere, a watchdog for the Pantheon Desktop
5 *5 *
6 * Copyright (C) 2011-2012 - Allen Lowe6 * Copyright (C) 2011-2017 - Allen Lowe
7 *7 *
8 * Cerbere is free software; you can redistribute it and/or modify8 * Cerbere is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by9 * it under the terms of the GNU General Public License as published by
@@ -36,12 +36,12 @@
3636
37 public void add_process (string command)37 public void add_process (string command)
38 requires (is_valid_command (command)) {38 requires (is_valid_command (command)) {
39 39
40 if (command_is_monitored (command)) {40 if (command_is_monitored (command)) {
41 warning ("Command '%s' is already being monitored.", command);41 warning ("Command '%s' is already being monitored.", command);
42 return;42 return;
43 }43 }
44 44
45 monitor_and_run_command (command);45 monitor_and_run_command (command);
46 }46 }
4747
@@ -52,7 +52,7 @@
52 private bool command_is_monitored (string command) {52 private bool command_is_monitored (string command) {
53 return processes.has_key (command);53 return processes.has_key (command);
54 }54 }
55 55
56 private void monitor_and_run_command (string command) {56 private void monitor_and_run_command (string command) {
57 var process = new ProcessWrapper (command);57 var process = new ProcessWrapper (command);
58 processes[command] = process;58 processes[command] = process;
@@ -97,11 +97,11 @@
9797
98 process.run_async ();98 process.run_async ();
99 }99 }
100 100
101 private bool is_not_in_settings (string command) {101 private bool is_not_in_settings (string command) {
102 return !(command in App.settings.process_list);102 return !(command in App.settings.process_list);
103 }103 }
104 104
105 private void unmonitor_command (string command) {105 private void unmonitor_command (string command) {
106 processes.unset (command);106 processes.unset (command);
107 }107 }

Subscribers

People subscribed via source and target branches

to all changes: