Merge lp:~larsu/qmenumodel/add-nameowner-property into lp:qmenumodel

Proposed by Lars Karlitski
Status: Merged
Approved by: Mirco Müller
Approved revision: 110
Merged at revision: 109
Proposed branch: lp:~larsu/qmenumodel/add-nameowner-property
Merge into: lp:qmenumodel
Diff against target: 84 lines (+20/-0)
3 files modified
debian/changelog (+6/-0)
libqmenumodel/src/unitymenumodel.cpp (+10/-0)
libqmenumodel/src/unitymenumodel.h (+4/-0)
To merge this branch: bzr merge lp:~larsu/qmenumodel/add-nameowner-property
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226428@code.launchpad.net

Commit message

unitymenumodel: add nameOwner property

Description of the change

unitymenumodel: add nameOwner property

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mirco Müller (macslow) wrote :

Looks good to me... and helps me with sorting out https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1308011

review: Approve
111. By Lars Karlitski

Update changelog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-07-04 07:38:12 +0000
+++ debian/changelog 2014-07-15 16:11:58 +0000
@@ -1,3 +1,9 @@
1qmenumodel (0.2.8-0ubuntu1) UNRELEASED; urgency=medium
2
3 * unitymenumodel: add nameOwner property
4
5 -- Lars Uebernickel <lars.uebernickel@ubuntu.com> Tue, 15 Jul 2014 18:10:54 +0200
6
1qmenumodel (0.2.7+14.10.20140704-0ubuntu1) utopic; urgency=low7qmenumodel (0.2.7+14.10.20140704-0ubuntu1) utopic; urgency=low
28
3 [ Charles Kerr ]9 [ Charles Kerr ]
410
=== modified file 'libqmenumodel/src/unitymenumodel.cpp'
--- libqmenumodel/src/unitymenumodel.cpp 2014-06-30 17:42:42 +0000
+++ libqmenumodel/src/unitymenumodel.cpp 2014-07-15 16:11:58 +0000
@@ -170,6 +170,8 @@
170170
171 this->updateActions();171 this->updateActions();
172 this->updateMenuModel();172 this->updateMenuModel();
173
174 Q_EMIT model->nameOwnerChanged (this->nameOwner);
173}175}
174176
175void UnityMenuModelPrivate::updateActions()177void UnityMenuModelPrivate::updateActions()
@@ -231,6 +233,8 @@
231233
232 priv->updateActions();234 priv->updateActions();
233 priv->updateMenuModel();235 priv->updateMenuModel();
236
237 Q_EMIT priv->model->nameOwnerChanged (priv->nameOwner);
234}238}
235239
236void UnityMenuModelPrivate::nameVanished(GDBusConnection *connection, const gchar *name, gpointer user_data)240void UnityMenuModelPrivate::nameVanished(GDBusConnection *connection, const gchar *name, gpointer user_data)
@@ -295,6 +299,11 @@
295 return priv->busName;299 return priv->busName;
296}300}
297301
302QByteArray UnityMenuModel::nameOwner() const
303{
304 return priv->nameOwner;
305}
306
298void UnityMenuModel::setBusName(const QByteArray &name)307void UnityMenuModel::setBusName(const QByteArray &name)
299{308{
300 if (name == priv->busName)309 if (name == priv->busName)
@@ -309,6 +318,7 @@
309 UnityMenuModelPrivate::nameAppeared, UnityMenuModelPrivate::nameVanished,318 UnityMenuModelPrivate::nameAppeared, UnityMenuModelPrivate::nameVanished,
310 priv, NULL);319 priv, NULL);
311 priv->busName = name;320 priv->busName = name;
321 Q_EMIT busNameChanged (priv->busName);
312}322}
313323
314QVariantMap UnityMenuModel::actions() const324QVariantMap UnityMenuModel::actions() const
315325
=== modified file 'libqmenumodel/src/unitymenumodel.h'
--- libqmenumodel/src/unitymenumodel.h 2013-09-03 10:02:47 +0000
+++ libqmenumodel/src/unitymenumodel.h 2014-07-15 16:11:58 +0000
@@ -28,6 +28,7 @@
28{28{
29 Q_OBJECT29 Q_OBJECT
30 Q_PROPERTY(QByteArray busName READ busName WRITE setBusName NOTIFY busNameChanged)30 Q_PROPERTY(QByteArray busName READ busName WRITE setBusName NOTIFY busNameChanged)
31 Q_PROPERTY(QByteArray nameOwner READ nameOwner NOTIFY nameOwnerChanged)
31 Q_PROPERTY(QVariantMap actions READ actions WRITE setActions NOTIFY actionsChanged)32 Q_PROPERTY(QVariantMap actions READ actions WRITE setActions NOTIFY actionsChanged)
32 Q_PROPERTY(QByteArray menuObjectPath READ menuObjectPath WRITE setMenuObjectPath NOTIFY menuObjectPathChanged)33 Q_PROPERTY(QByteArray menuObjectPath READ menuObjectPath WRITE setMenuObjectPath NOTIFY menuObjectPathChanged)
33 Q_PROPERTY(ActionStateParser* actionStateParser READ actionStateParser WRITE setActionStateParser NOTIFY actionStateParserChanged)34 Q_PROPERTY(ActionStateParser* actionStateParser READ actionStateParser WRITE setActionStateParser NOTIFY actionStateParserChanged)
@@ -39,6 +40,8 @@
39 QByteArray busName() const;40 QByteArray busName() const;
40 void setBusName(const QByteArray &name);41 void setBusName(const QByteArray &name);
4142
43 QByteArray nameOwner() const;
44
42 QVariantMap actions() const;45 QVariantMap actions() const;
43 void setActions(const QVariantMap &actions);46 void setActions(const QVariantMap &actions);
4447
@@ -67,6 +70,7 @@
6770
68Q_SIGNALS:71Q_SIGNALS:
69 void busNameChanged(const QByteArray &name);72 void busNameChanged(const QByteArray &name);
73 void nameOwnerChanged(const QByteArray &owner);
70 void actionsChanged(const QByteArray &path);74 void actionsChanged(const QByteArray &path);
71 void menuObjectPathChanged(const QByteArray &path);75 void menuObjectPathChanged(const QByteArray &path);
72 void actionStateParserChanged(ActionStateParser* parser);76 void actionStateParserChanged(ActionStateParser* parser);

Subscribers

People subscribed via source and target branches