Merge lp:~larsu/nautilus/set-max-width-for-properties-window into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Lars Karlitski
Status: Merged
Merged at revision: 439
Proposed branch: lp:~larsu/nautilus/set-max-width-for-properties-window
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 55 lines (+35/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/git_properties_window_set_max_width_for_value_labels.patch (+27/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~larsu/nautilus/set-max-width-for-properties-window
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+237301@code.launchpad.net

Commit message

* debian/patches/properties_window_set_max_width_for_value_labels.patch:
  - avoid very wide properties window (GNOME: #732117)

Description of the change

* debian/patches/properties_window_set_max_width_for_value_labels.patch:
  - avoid very wide properties window (GNOME: #732117)

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Just pushed this to upstream master. Should I rename the patch to git_*?

Revision history for this message
Sebastien Bacher (seb128) wrote :

renaming to git_ would be nicer, looks good to commit otherwise

review: Approve
440. By Lars Karlitski

Rename properties_window_set_max_width_for_value_labels

It was accespted upstream.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-09-30 16:59:37 +0000
+++ debian/changelog 2014-10-08 07:59:36 +0000
@@ -1,3 +1,10 @@
1nautilus (1:3.10.1-0ubuntu15) UNRELEASED; urgency=medium
2
3 * debian/patches/properties_window_set_max_width_for_value_labels.patch:
4 - avoid very wide properties window (GNOME: #732117)
5
6 -- Lars Uebernickel <lars.uebernickel@ubuntu.com> Mon, 06 Oct 2014 17:23:30 +0200
7
1nautilus (1:3.10.1-0ubuntu14) utopic; urgency=medium8nautilus (1:3.10.1-0ubuntu14) utopic; urgency=medium
29
3 * No-change rebuild for gnome-desktop 3.1210 * No-change rebuild for gnome-desktop 3.12
411
=== added file 'debian/patches/git_properties_window_set_max_width_for_value_labels.patch'
--- debian/patches/git_properties_window_set_max_width_for_value_labels.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git_properties_window_set_max_width_for_value_labels.patch 2014-10-08 07:59:36 +0000
@@ -0,0 +1,27 @@
1From 0618af5a154cff26c7a04b303abcbeec2a8ca10d Mon Sep 17 00:00:00 2001
2From: Lars Uebernickel <lars.uebernickel@canonical.com>
3Date: Mon, 6 Oct 2014 13:07:51 +0200
4Subject: [PATCH] properties-window: set max-width for value labels
5
6Not setting it can lead to very wide windows, because gtk doesn't
7enforce a maximum window size anymore.
8
9https://bugzilla.gnome.org/show_bug.cgi?id=732117
10---
11 src/nautilus-properties-window.c | 1 +
12 1 file changed, 1 insertion(+)
13
14diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
15index 3b15dd9..631c456 100644
16--- a/src/nautilus-properties-window.c
17+++ b/src/nautilus-properties-window.c
18@@ -1276,6 +1276,7 @@ attach_label (GtkGrid *grid,
19
20 if (ellipsize_text) {
21 gtk_widget_set_hexpand (label_field, TRUE);
22+ gtk_label_set_max_width_chars (GTK_LABEL (label_field), 24);
23 }
24
25 if (sibling != NULL) {
26--
272.1.0
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-09-29 16:57:17 +0000
+++ debian/patches/series 2014-10-08 07:59:36 +0000
@@ -42,3 +42,4 @@
420001-Don-t-try-to-open-a-selection-if-we-don-t-have-one.patch420001-Don-t-try-to-open-a-selection-if-we-don-t-have-one.patch
43git_also_tracker-1.0.patch43git_also_tracker-1.0.patch
44ubuntu_tracker_only_on_GNOME.patch44ubuntu_tracker_only_on_GNOME.patch
45git_properties_window_set_max_width_for_value_labels.patch

Subscribers

People subscribed via source and target branches

to all changes: