Merge lp:~larsu/gtk/lp1339495 into lp:~ubuntu-desktop/gtk/ubuntugtk3

Proposed by Lars Karlitski
Status: Merged
Merged at revision: 357
Proposed branch: lp:~larsu/gtk/lp1339495
Merge into: lp:~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 96 lines (+76/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/git_reftests-Improve-workaround-for-GtkGrid-bug.patch (+68/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~larsu/gtk/lp1339495
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
VCS imports Pending
Review via email: mp+226430@code.launchpad.net

This proposal supersedes a proposal from 2014-07-11.

Description of the change

Backport reftests-Improve-workaround-for-GtkGrid-bug from master

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-06-18 15:40:12 +0000
+++ debian/changelog 2014-07-11 10:08:58 +0000
@@ -1,3 +1,10 @@
1gtk+3.0 (3.12.2-0ubuntu5) UNRELEASED; urgency=medium
2
3 * debian/patches/git_reftests-Improve-workaround-for-GtkGrid-bug.patch:
4 - backport from master (lp: #1339495)
5
6 -- Lars Uebernickel <lars.uebernickel@ubuntu.com> Fri, 11 Jul 2014 12:05:56 +0200
7
1gtk+3.0 (3.12.2-0ubuntu4) utopic; urgency=medium8gtk+3.0 (3.12.2-0ubuntu4) utopic; urgency=medium
29
3 * debian/patches/git-gtkpopover-set-background-and-popover-css.patch10 * debian/patches/git-gtkpopover-set-background-and-popover-css.patch
411
=== added file 'debian/patches/git_reftests-Improve-workaround-for-GtkGrid-bug.patch'
--- debian/patches/git_reftests-Improve-workaround-for-GtkGrid-bug.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git_reftests-Improve-workaround-for-GtkGrid-bug.patch 2014-07-11 10:08:58 +0000
@@ -0,0 +1,68 @@
1From 6a2ae1bb9058086acfc1e2a9da6f4163b876af1e Mon Sep 17 00:00:00 2001
2From: Benjamin Otte <otte@redhat.com>
3Date: Thu, 10 Jul 2014 14:16:06 +0200
4Subject: [PATCH] reftests: Improve workaround for GtkGrid bug
5
6... so that it works with wide separators. Or rather: with separators
7that don't request 1px size but any other number. Do that by making the
8placeholder request the same size by indeed stuffing (hidden) separators
9in it.
10---
11 testsuite/reftests/separator-size.ui | 36 ++++++++++++++++++++++++++++++------
12 1 file changed, 30 insertions(+), 6 deletions(-)
13
14diff --git a/testsuite/reftests/separator-size.ui b/testsuite/reftests/separator-size.ui
15index 006c44e..ae109b6 100644
16--- a/testsuite/reftests/separator-size.ui
17+++ b/testsuite/reftests/separator-size.ui
18@@ -126,17 +126,41 @@
19 <!-- BEGIN REMOVE WHEN GRID FIXED -->
20
21 <child>
22- <object class="GtkBox" id="remove-me-when-grid-is-fixed">
23+ <object class="GtkNotebook" id="notebook1">
24 <property name="visible">True</property>
25- <property name="can_focus">False</property>
26- <property name="width-request">1</property>
27- <property name="height-request">1</property>
28+ <property name="can_focus">True</property>
29+ <property name="show_tabs">False</property>
30+ <property name="show_border">False</property>
31+ <child>
32+ <object class="GtkBox" id="box5">
33+ <property name="visible">True</property>
34+ <property name="can_focus">False</property>
35+ <property name="orientation">vertical</property>
36+ </object>
37+ </child>
38+ <child>
39+ <object class="GtkSeparator" id="separator5">
40+ <property name="visible">True</property>
41+ <property name="can_focus">False</property>
42+ </object>
43+ <packing>
44+ <property name="position">1</property>
45+ </packing>
46+ </child>
47+ <child>
48+ <object class="GtkSeparator" id="separator6">
49+ <property name="visible">True</property>
50+ <property name="can_focus">False</property>
51+ <property name="orientation">vertical</property>
52+ </object>
53+ <packing>
54+ <property name="position">2</property>
55+ </packing>
56+ </child>
57 </object>
58 <packing>
59 <property name="left_attach">1</property>
60 <property name="top_attach">1</property>
61- <property name="width">1</property>
62- <property name="height">1</property>
63 </packing>
64 </child>
65
66--
672.0.1
68
069
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-06-18 15:39:36 +0000
+++ debian/patches/series 2014-07-11 10:08:58 +0000
@@ -21,3 +21,4 @@
21gtkaboutdialog-support-showing-buttons-in-action-are.patch21gtkaboutdialog-support-showing-buttons-in-action-are.patch
22message-dialog-restore-traditional-look-on-unity.patch22message-dialog-restore-traditional-look-on-unity.patch
23git-gtkpopover-set-background-and-popover-css.patch23git-gtkpopover-set-background-and-popover-css.patch
24git_reftests-Improve-workaround-for-GtkGrid-bug.patch

Subscribers

People subscribed via source and target branches

to all changes: