Ubuntu Software Center

Merge lp:~laney/software-center/ssl-disable-cert-wording into lp:software-center

  1. ssl-disable-cert-wording
  2. Merge into trunk
Proposed by Iain Lane
Status: Approved
Approved by: dobey
Approved revision: 3346
Proposed branch: lp:~laney/software-center/ssl-disable-cert-wording
Merge into: lp:software-center
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/ui/gtk3/widgets/webkit.py (+1/-1)
To merge this branch: bzr merge lp:~laney/software-center/ssl-disable-cert-wording
Reviewer Review Type Date Requested Status
dobey Approve
Review via email: mp+286512@code.launchpad.net

Commit message

webkit.py: If we're disabling the certificate check, things aren't unencrypted - just insecure (no validation)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Reply

Unmerged revisions

3346. By Iain Lane

webkit.py: If we're disabling the certificate check, things aren't unencrypted - just insecure (no validation)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk3/widgets/webkit.py'
--- softwarecenter/ui/gtk3/widgets/webkit.py 2015-07-14 14:55:08 +0000
+++ softwarecenter/ui/gtk3/widgets/webkit.py 2016-02-18 14:24:30 +0000
@@ -50,7 +50,7 @@
50 # WARN the user!! Do not remove this50 # WARN the user!! Do not remove this
51 LOG.warning("SOFTWARE_CENTER_FORCE_DISABLE_CERTS_CHECK " +51 LOG.warning("SOFTWARE_CENTER_FORCE_DISABLE_CERTS_CHECK " +
52 "has been specified, all purchase transactions " +52 "has been specified, all purchase transactions " +
53 "are now INSECURE and UNENCRYPTED!!")53 "are now potentially INSECURE!")
5454
55 # cookies by default55 # cookies by default
56 fname = os.path.join(SOFTWARE_CENTER_CACHE_DIR, "cookies.txt")56 fname = os.path.join(SOFTWARE_CENTER_CACHE_DIR, "cookies.txt")