Merge lp:~laney/gnome-menus/add-forgotten-symbol into lp:~ubuntu-desktop/gnome-menus/ubuntu

Proposed by Iain Lane
Status: Merged
Merged at revision: 120
Proposed branch: lp:~laney/gnome-menus/add-forgotten-symbol
Merge into: lp:~ubuntu-desktop/gnome-menus/ubuntu
Diff against target: 92 lines (+61/-0)
4 files modified
debian/changelog (+7/-0)
debian/libgnome-menu-3-0.symbols (+1/-0)
debian/patches/forgotten-gmenu-separator-api (+52/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~laney/gnome-menus/add-forgotten-symbol
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Ubuntu Sponsors Pending
Review via email: mp+109675@code.launchpad.net

Description of the change

I need this patch to fix bug #1010800, which is an annoying crash in alacarte whenever there is a separator.

To post a comment you must log in.
120. By Iain Lane

Take patch from upstream bug #677344 to add a forgotten API
gmenu_tree_iter_get_separator. Unbreaks alacarte. (LP: #1010800)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-06-06 02:20:46 +0000
+++ debian/changelog 2012-06-11 16:07:19 +0000
@@ -1,3 +1,10 @@
1gnome-menus (3.5.2-0ubuntu2) UNRELEASED; urgency=low
2
3 * Take patch from upstream bug #677344 to add a forgotten API
4 gmenu_tree_iter_get_separator. Unbreaks alacarte. (LP: #1010800)
5
6 -- Iain Lane <iain.lane@canonical.com> Mon, 11 Jun 2012 16:17:52 +0100
7
1gnome-menus (3.5.2-0ubuntu1) quantal-proposed; urgency=low8gnome-menus (3.5.2-0ubuntu1) quantal-proposed; urgency=low
29
3 * New upstream release10 * New upstream release
411
=== modified file 'debian/libgnome-menu-3-0.symbols'
--- debian/libgnome-menu-3-0.symbols 2012-06-06 02:20:46 +0000
+++ debian/libgnome-menu-3-0.symbols 2012-06-11 16:07:19 +0000
@@ -36,6 +36,7 @@
36 gmenu_tree_iter_get_directory@Base 3.2.0.136 gmenu_tree_iter_get_directory@Base 3.2.0.1
37 gmenu_tree_iter_get_entry@Base 3.2.0.137 gmenu_tree_iter_get_entry@Base 3.2.0.1
38 gmenu_tree_iter_get_header@Base 3.2.0.138 gmenu_tree_iter_get_header@Base 3.2.0.1
39 gmenu_tree_iter_get_separator@Base 3.5.2-0ubuntu2~
39 gmenu_tree_iter_get_type@Base 3.2.0.140 gmenu_tree_iter_get_type@Base 3.2.0.1
40 gmenu_tree_iter_next@Base 3.2.0.141 gmenu_tree_iter_next@Base 3.2.0.1
41 gmenu_tree_iter_ref@Base 3.2.0.142 gmenu_tree_iter_ref@Base 3.2.0.1
4243
=== added file 'debian/patches/forgotten-gmenu-separator-api'
--- debian/patches/forgotten-gmenu-separator-api 1970-01-01 00:00:00 +0000
+++ debian/patches/forgotten-gmenu-separator-api 2012-06-11 16:07:19 +0000
@@ -0,0 +1,52 @@
1From: "Jasper St. Pierre" <jstpierre@mecheye.net>
2Date: Sat, 2 Jun 2012 13:27:24 -0400
3Subject: [PATCH] libmenu: Add the forgotten gmenu_tree_iter_get_separator
4Bug-Upstream: https://bugzilla.gnome.org/show_bug.cgi?id=677344
5
6---
7 libmenu/gmenu-tree.c | 19 +++++++++++++++++++
8 libmenu/gmenu-tree.h | 1 +
9 2 files changed, 20 insertions(+)
10
11Index: gnome-menus-3.5.2/libmenu/gmenu-tree.c
12===================================================================
13--- gnome-menus-3.5.2.orig/libmenu/gmenu-tree.c 2012-05-25 19:34:25.000000000 +0100
14+++ gnome-menus-3.5.2/libmenu/gmenu-tree.c 2012-06-11 16:17:18.004596713 +0100
15@@ -1039,6 +1039,25 @@
16 return (GMenuTreeAlias*)gmenu_tree_item_ref (iter->item);
17 }
18
19+/**
20+ * gmenu_tree_iter_get_separator:
21+ * @iter: iter
22+ *
23+ * This method may only be called if gmenu_tree_iter_next()
24+ * returned #GMENU_TREE_ITEM_SEPARATOR.
25+ *
26+ * Returns: (transfer full): A separator
27+ */
28+GMenuTreeSeparator *
29+gmenu_tree_iter_get_separator (GMenuTreeIter *iter)
30+{
31+ g_return_val_if_fail (iter != NULL, NULL);
32+ g_return_val_if_fail (iter->item != NULL, NULL);
33+ g_return_val_if_fail (iter->item->type == GMENU_TREE_ITEM_SEPARATOR, NULL);
34+
35+ return (GMenuTreeSeparator*)gmenu_tree_item_ref (iter->item);
36+}
37+
38 const char *
39 gmenu_tree_directory_get_name (GMenuTreeDirectory *directory)
40 {
41Index: gnome-menus-3.5.2/libmenu/gmenu-tree.h
42===================================================================
43--- gnome-menus-3.5.2.orig/libmenu/gmenu-tree.h 2012-05-25 19:34:25.000000000 +0100
44+++ gnome-menus-3.5.2/libmenu/gmenu-tree.h 2012-06-11 16:17:18.004596713 +0100
45@@ -125,6 +125,7 @@
46 GMenuTreeEntry *gmenu_tree_iter_get_entry (GMenuTreeIter *iter);
47 GMenuTreeHeader *gmenu_tree_iter_get_header (GMenuTreeIter *iter);
48 GMenuTreeAlias *gmenu_tree_iter_get_alias (GMenuTreeIter *iter);
49+GMenuTreeSeparator *gmenu_tree_iter_get_separator (GMenuTreeIter *iter);
50
51 char *gmenu_tree_directory_make_path (GMenuTreeDirectory *directory,
52 GMenuTreeEntry *entry);
053
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-02-29 21:34:18 +0000
+++ debian/patches/series 2012-06-11 16:07:19 +0000
@@ -10,3 +10,4 @@
1021_default-python-in-shebang.patch1021_default-python-in-shebang.patch
1122_directory-suffix-for-icons.patch1122_directory-suffix-for-icons.patch
1270_ubuntu-directories.patch1270_ubuntu-directories.patch
13forgotten-gmenu-separator-api

Subscribers

People subscribed via source and target branches