Merge lp:~laney/gdebi/vte2.91 into lp:gdebi

Proposed by Iain Lane
Status: Merged
Merged at revision: 486
Proposed branch: lp:~laney/gdebi/vte2.91
Merge into: lp:gdebi
Diff against target: 94 lines (+14/-8)
3 files modified
GDebi/GDebiGtk.py (+6/-6)
debian/changelog (+6/-0)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~laney/gdebi/vte2.91
Reviewer Review Type Date Requested Status
Michael Vogt Pending
gdebi-developers Pending
Review via email: mp+242059@code.launchpad.net

Description of the change

Port to vte 2.91

This isn't urgent because of the gi.require_version, but I'd still like to get everything off the 2.90 gir if possible.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'GDebi/GDebiGtk.py'
--- GDebi/GDebiGtk.py 2014-04-22 12:48:15 +0000
+++ GDebi/GDebiGtk.py 2014-11-18 11:46:15 +0000
@@ -40,7 +40,7 @@
4040
41import gi41import gi
42gi.require_version("Gtk", "3.0")42gi.require_version("Gtk", "3.0")
43gi.require_version("Vte", "2.90")43gi.require_version("Vte", "2.91")
44from gi.repository import Gtk44from gi.repository import Gtk
45from gi.repository import GObject45from gi.repository import GObject
46from gi.repository import GLib46from gi.repository import GLib
@@ -866,9 +866,8 @@
866 self.term_expander.set_expanded(False)866 self.term_expander.set_expanded(False)
867 self.install = install867 self.install = install
868 def commit(self):868 def commit(self):
869 def finish_dpkg(term, lock):869 def finish_dpkg(term, status, lock):
870 """ helper that is run when dpkg finishes """870 """ helper that is run when dpkg finishes """
871 status = term.get_child_exit_status()
872 self.exitstatus = posix.WEXITSTATUS(status)871 self.exitstatus = posix.WEXITSTATUS(status)
873 #print "dpkg finished %s %s" % (pid,status)872 #print "dpkg finished %s %s" % (pid,status)
874 #print "exit status: %s" % self.exitstatus873 #print "exit status: %s" % self.exitstatus
@@ -922,7 +921,7 @@
922921
923 # prepare for the fork922 # prepare for the fork
924 self.term.connect("child-exited", finish_dpkg, lock)923 self.term.connect("child-exited", finish_dpkg, lock)
925 (res, pid) =self.term.fork_command_full(924 (res, pid) =self.term.spawn_sync(
926 Vte.PtyFlags.DEFAULT,925 Vte.PtyFlags.DEFAULT,
927 "/",926 "/",
928 argv,927 argv,
@@ -931,6 +930,7 @@
931 # FIXME: add setup_func that closes all fds excpet for writefd930 # FIXME: add setup_func that closes all fds excpet for writefd
932 None, #setup_func931 None, #setup_func
933 None, #setup_data932 None, #setup_data
933 None, #cancellable
934 )934 )
935 #print "fork_command_full: ", res, pid935 #print "fork_command_full: ", res, pid
936936
@@ -1015,7 +1015,7 @@
1015 # sleep just long enough to not create a busy loop1015 # sleep just long enough to not create a busy loop
1016 time.sleep(0.01)1016 time.sleep(0.01)
1017 def fork(self):1017 def fork(self):
1018 pty = Vte.Pty.new(Vte.PtyFlags.DEFAULT)1018 pty = Vte.Pty.new_sync(Vte.PtyFlags.DEFAULT)
1019 pid = os.fork()1019 pid = os.fork()
1020 if pid == 0:1020 if pid == 0:
1021 # *grumpf* workaround bug in vte here (gnome bug #588871)1021 # *grumpf* workaround bug in vte here (gnome bug #588871)
@@ -1026,7 +1026,7 @@
1026 pty.child_setup()1026 pty.child_setup()
1027 # FIXME: close all fds expect for self.writefd1027 # FIXME: close all fds expect for self.writefd
1028 else:1028 else:
1029 self.term.set_pty_object(pty)1029 self.term.set_pty(pty)
1030 self.term.watch_child(pid)1030 self.term.watch_child(pid)
1031 return pid1031 return pid
1032 def wait_child(self):1032 def wait_child(self):
10331033
=== modified file 'debian/changelog'
--- debian/changelog 2014-09-29 07:13:24 +0000
+++ debian/changelog 2014-11-18 11:46:15 +0000
@@ -1,3 +1,9 @@
1gdebi (0.9.5.6) UNRELEASED; urgency=medium
2
3 * Use vte 2.91
4
5 -- Iain Lane <iain@orangesquash.org.uk> Tue, 18 Nov 2014 10:54:30 +0000
6
1gdebi (0.9.5.5) unstable; urgency=medium7gdebi (0.9.5.5) unstable; urgency=medium
28
3 * Team upload.9 * Team upload.
410
=== modified file 'debian/control'
--- debian/control 2014-09-29 07:07:27 +0000
+++ debian/control 2014-11-18 11:46:15 +0000
@@ -6,7 +6,7 @@
6Build-Depends: debhelper (>= 9),6Build-Depends: debhelper (>= 9),
7 dh-python,7 dh-python,
8 gir1.2-gtk-3.0,8 gir1.2-gtk-3.0,
9 gir1.2-vte-2.90,9 gir1.2-vte-2.91,
10 python3-all,10 python3-all,
11 python3-apt,11 python3-apt,
12 python3-gi,12 python3-gi,
@@ -44,7 +44,7 @@
44 ${misc:Depends},44 ${misc:Depends},
45 gdebi-core (= ${source:Version}),45 gdebi-core (= ${source:Version}),
46 gir1.2-gtk-3.0,46 gir1.2-gtk-3.0,
47 gir1.2-vte-2.90,47 gir1.2-vte-2.91,
48 python3-gi,48 python3-gi,
49 gksu,49 gksu,
50 gnome-icon-theme50 gnome-icon-theme

Subscribers

People subscribed via source and target branches

to status/vote changes: