Merge lp:~l-admin-3/eidete/gtk-314-fix into lp:eidete

Proposed by Marcus Wichelmann
Status: Rejected
Rejected by: Corentin Noël
Proposed branch: lp:~l-admin-3/eidete/gtk-314-fix
Merge into: lp:eidete
Diff against target: 12 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~l-admin-3/eidete/gtk-314-fix
Reviewer Review Type Date Requested Status
Cody Garver (community) Disapprove
Review via email: mp+246933@code.launchpad.net

Commit message

Gtk-Version updated.

Description of the change

I've updated the Gtk-version to 3.14 so launchpad will build eidete with the newer version and hopefully the dialog-margins are working after that. ;)

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

This will not influence what Gtk version Launchpad builds with, only packaging could. And Launchpad actually already is using Gtk 3.14 https://launchpadlibrarian.net/195132142/buildlog_ubuntu-trusty-amd64.eidete_0.1~r188-0%2Bpkg16~ubuntu0.3.1_UPLOADING.txt.gz

review: Disapprove

Unmerged revisions

189. By Marcus Wichelmann

Gtk-Version updated.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-01-04 14:53:16 +0000
+++ CMakeLists.txt 2015-01-19 18:18:06 +0000
@@ -45,7 +45,7 @@
45add_definitions(-DGETTEXT_PACKAGE=\"${GETTEXT_PACKAGE}\" -DWNCK_I_KNOW_THIS_IS_UNSTABLE)45add_definitions(-DGETTEXT_PACKAGE=\"${GETTEXT_PACKAGE}\" -DWNCK_I_KNOW_THIS_IS_UNSTABLE)
4646
47find_package(PkgConfig)47find_package(PkgConfig)
48pkg_check_modules(DEPS REQUIRED gtk+-3.0>=3.1048pkg_check_modules(DEPS REQUIRED gtk+-3.0>=3.14
49 libwnck-3.049 libwnck-3.0
50 granite50 granite
51 xtst51 xtst

Subscribers

People subscribed via source and target branches