snappy-hwe-snaps

Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/udisks2-default-interfaces into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests
  3. fix/udisks2-default-interfaces
  4. Merge into master
Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: ac6b7f05595a50e00107a2279ee62c18e4271fbc
Merged at revision: 89d66512a794b098077da21444cd67cab96ccbc7
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/udisks2-default-interfaces
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 11 lines (+1/-0)
1 file modified
udisks2/units/udisks2.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+325386@code.launchpad.net

This proposal supersedes a proposal from 2017-06-09.

Description of the change

udisks2: add network-bind interface connection

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:ac6b7f05595a50e00107a2279ee62c18e4271fbc
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1608/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2008/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1515/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1608/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Why do we need network-bind?

review: Needs Information
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:ac6b7f05595a50e00107a2279ee62c18e4271fbc
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1610/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2010
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1517/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2381
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1568/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1610/rebuild

review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Sorry, was confused. LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:ac6b7f05595a50e00107a2279ee62c18e4271fbc
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1609/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2009
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1518/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2382
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1569/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1609/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/udisks2/units/udisks2.pxu b/udisks2/units/udisks2.pxu
index 7006baf..7667aa5 100644
--- a/udisks2/units/udisks2.pxu
+++ b/udisks2/units/udisks2.pxu
@@ -20,6 +20,7 @@ _verification:
20 Verify that you see the following:20 Verify that you see the following:
21 Slot Plug21 Slot Plug
22 :mount-observe udisks222 :mount-observe udisks2
23 :network-bind udisks2
23 udisks2:service udisks2:client24 udisks2:service udisks2:client
24 - udisks2:hardware-observe25 - udisks2:hardware-observe
2526

Subscribers

People subscribed via source and target branches