Merge lp:~knocte/ubuntu-themes/bring-back-zebra-striping into lp:ubuntu-themes

Proposed by Andres G. Aragoneses
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 331
Merged at revision: 334
Proposed branch: lp:~knocte/ubuntu-themes/bring-back-zebra-striping
Merge into: lp:ubuntu-themes
Diff against target: 23 lines (+4/-2)
1 file modified
Ambiance/gtk-3.0/gtk-widgets.css (+4/-2)
To merge this branch: bzr merge lp:~knocte/ubuntu-themes/bring-back-zebra-striping
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Cimitan Approve
Review via email: mp+200429@code.launchpad.net

Commit message

Ambiance: support zebra striping for treeviews

This is a rework of Andrea's patch (committed in r220:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/220)
that doesn't introduce a visual glitch on progress bars
inside treeviews (because of this visual glitch, the
r220 patch was reverted in r234:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/234
and bug LP#945430 had to be reopened), and therefore
allows us to have a theme that implements zebra
striping treeviews when applications choose to use
them via `self.treeview.set_rules_hint(True)` API.

Description of the change

Ambiance: support zebra striping for treeviews

This is a rework of Andrea's patch (committed in r220:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/220)
that doesn't introduce a visual glitch on progress bars
inside treeviews (because of this visual glitch, the
r220 patch was reverted in r234:
http://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/revision/234
and bug LP#945430 had to be reopened), and therefore
allows us to have a theme that implements zebra
striping treeviews when applications choose to use
them via `self.treeview.set_rules_hint(True)` API.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.0/gtk-widgets.css'
--- Ambiance/gtk-3.0/gtk-widgets.css 2013-11-25 16:46:01 +0000
+++ Ambiance/gtk-3.0/gtk-widgets.css 2014-01-03 19:16:53 +0000
@@ -1280,7 +1280,8 @@
1280.progressbar row,1280.progressbar row,
1281.progressbar row:hover,1281.progressbar row:hover,
1282.progressbar row:selected,1282.progressbar row:selected,
1283.progressbar row:selected:focused {1283.progressbar row:selected:focused,
1284.progressbar row:nth-child(odd) {
1284 border-radius: 8px;1285 border-radius: 8px;
1285 border-width: 0px;1286 border-width: 0px;
1286 background-image: none;1287 background-image: none;
@@ -2391,7 +2392,8 @@
2391}2392}
23922393
2393GtkTreeView row:nth-child(odd) {2394GtkTreeView row:nth-child(odd) {
2394 /*background-color: shade (@base_color, 0.965);*/2395 /* zebra stripping, see LP#945430 */
2396 background-color: shade (@base_color, 0.965);
2395}2397}
23962398
2397/************2399/************

Subscribers

People subscribed via source and target branches