Merge ~kissiel/plainbox:fix-1741109-hide-automated into plainbox:master

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Maciej Kisielewski
Approved revision: 5089b53d04987a8d6a2eb6e5de96fa5f641977fb
Merged at revision: 2d876a090dbfafa14c259f629a23529c8ffbeeef
Proposed branch: ~kissiel/plainbox:fix-1741109-hide-automated
Merge into: plainbox:master
Diff against target: 14 lines (+2/-1)
1 file modified
plainbox/impl/launcher.py (+2/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email: mp+335887@code.launchpad.net

Description of the change

Add 'hide-automated' as a valid option to the 'output' variable in [ui] section in configs/launchers.

This variable is listed on http://checkbox.readthedocs.io/en/latest/launcher-tutorial.html and the code did not actually support it. The logic was there, just the declaration was missing in the config module.

This MR adds this declaration.

To test it use launcher with this section in it:

[ui]
output = hide-automated

It should behave just as 'hide' would.

TBH I don't know why we missed to land this earlier.

Fixes: LP:1741109

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/plainbox/impl/launcher.py b/plainbox/impl/launcher.py
index 034c613..381c751 100644
--- a/plainbox/impl/launcher.py
+++ b/plainbox/impl/launcher.py
@@ -166,7 +166,8 @@ class LauncherDefinition1(LauncherDefinition):
166 section='ui',166 section='ui',
167 default='show',167 default='show',
168 validator_list=[config.ChoiceValidator(168 validator_list=[config.ChoiceValidator(
169 ['show', 'hide', 'hide-resource-and-attachment'])],169 ['show', 'hide', 'hide-resource-and-attachment',
170 'hide-automated'])],
170 help_text=_('Silence or restrict command output'))171 help_text=_('Silence or restrict command output'))
171172
172 dont_suppress_output = config.Variable(173 dont_suppress_output = config.Variable(

Subscribers

People subscribed via source and target branches