Merge lp:~khadgaray/unity-greeter/default-background-color into lp:unity-greeter

Proposed by Ritesh Khadgaray
Status: Merged
Merge reported by: Robert Ancell
Merged at revision: not available
Proposed branch: lp:~khadgaray/unity-greeter/default-background-color
Merge into: lp:unity-greeter
Diff against target: 52 lines (+7/-2)
4 files modified
data/com.canonical.unity-greeter.gschema.xml (+4/-0)
src/background.vala (+1/-1)
src/main-window.vala (+1/-1)
src/settings.vala (+1/-0)
To merge this branch: bzr merge lp:~khadgaray/unity-greeter/default-background-color
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+102067@code.launchpad.net

Description of the change

lp# 969059 - Default background colour hardcoded to #2C001E

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Ritesh!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/com.canonical.unity-greeter.gschema.xml'
--- data/com.canonical.unity-greeter.gschema.xml 2012-03-01 14:17:05 +0000
+++ data/com.canonical.unity-greeter.gschema.xml 2012-04-16 08:38:20 +0000
@@ -5,6 +5,10 @@
5 <default>'/usr/share/backgrounds/warty-final-ubuntu.png'</default>5 <default>'/usr/share/backgrounds/warty-final-ubuntu.png'</default>
6 <summary>Background file to use, either an image path or a color (e.g. #772953)</summary>6 <summary>Background file to use, either an image path or a color (e.g. #772953)</summary>
7 </key>7 </key>
8 <key name="background-color" type="s">
9 <default>'#2C001E'</default>
10 <summary>Background color (e.g. #772953), set before wallpaper is seen</summary>
11 </key>
8 <key name="draw-user-backgrounds" type="b">12 <key name="draw-user-backgrounds" type="b">
9 <default>true</default>13 <default>true</default>
10 <summary>Whether to draw user backgrounds</summary>14 <summary>Whether to draw user backgrounds</summary>
1115
=== modified file 'src/background.vala'
--- src/background.vala 2012-04-03 18:00:30 +0000
+++ src/background.vala 2012-04-16 08:38:20 +0000
@@ -227,7 +227,7 @@
227 GRID,227 GRID,
228 }228 }
229229
230 public string default_background {get; set; default = "#2C001E";}230 public string default_background {get; set; default = UGSettings.get_string (UGSettings.KEY_BACKGROUND_COLOR);}
231 public string? current_background {get; set; default = null;}231 public string? current_background {get; set; default = null;}
232 public bool draw_grid {get; set; default = true;}232 public bool draw_grid {get; set; default = true;}
233 public double alpha {get; private set; default = 1.0;}233 public double alpha {get; private set; default = 1.0;}
234234
=== modified file 'src/main-window.vala'
--- src/main-window.vala 2012-03-13 14:27:50 +0000
+++ src/main-window.vala 2012-04-16 08:38:20 +0000
@@ -37,7 +37,7 @@
37 add_accel_group (accel_group);37 add_accel_group (accel_group);
3838
39 var bg_color = Gdk.RGBA ();39 var bg_color = Gdk.RGBA ();
40 bg_color.parse ("#2C001E");40 bg_color.parse (UGSettings.get_string (UGSettings.KEY_BACKGROUND_COLOR));
41 override_background_color (Gtk.StateFlags.NORMAL, bg_color);41 override_background_color (Gtk.StateFlags.NORMAL, bg_color);
42 get_accessible ().set_name (_("Login Screen"));42 get_accessible ().set_name (_("Login Screen"));
43 has_resize_grip = false;43 has_resize_grip = false;
4444
=== modified file 'src/settings.vala'
--- src/settings.vala 2012-03-01 14:17:05 +0000
+++ src/settings.vala 2012-04-16 08:38:20 +0000
@@ -21,6 +21,7 @@
21public class UGSettings21public class UGSettings
22{22{
23 public static const string KEY_BACKGROUND = "background";23 public static const string KEY_BACKGROUND = "background";
24 public static const string KEY_BACKGROUND_COLOR = "background-color";
24 public static const string KEY_DRAW_USER_BACKGROUNDS = "draw-user-backgrounds";25 public static const string KEY_DRAW_USER_BACKGROUNDS = "draw-user-backgrounds";
25 public static const string KEY_DRAW_GRID = "draw-grid";26 public static const string KEY_DRAW_GRID = "draw-grid";
26 public static const string KEY_LOGO = "logo";27 public static const string KEY_LOGO = "logo";

Subscribers

People subscribed via source and target branches