Merge lp:~ken-vandine/unity8/share_data_uri_string into lp:unity8
Proposed by
Ken VanDine
Status: | Rejected |
---|---|
Rejected by: | Andrea Cimitan |
Proposed branch: | lp:~ken-vandine/unity8/share_data_uri_string |
Merge into: | lp:unity8 |
Diff against target: |
18 lines (+3/-5) 1 file modified
qml/Dash/Previews/PreviewSharing.qml (+3/-5) |
To merge this branch: | bzr merge lp:~ken-vandine/unity8/share_data_uri_string |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Cimitan (community) | Disapprove | ||
Michael Zanetti (community) | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Unity8 CI Bot | continuous-integration | Approve | |
Review via email: mp+286676@code.launchpad.net |
Commit message
shareData["uri"] should be a string, not an array so lets treat it as such.
Description of the change
shareData["uri"] should be a string, not an array so lets treat it as such.
To post a comment you must log in.
Unmerged revisions
- 2204. By Ken VanDine
-
shareData["uri"] should be a string, not an array so lets treat it as such.
- 2203. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2202. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2201. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2200. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
PASSED: Continuous integration, rev:2204 /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/443/ /unity8- jenkins. ubuntu. com/job/ build/598 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= vivid+overlay/ 187 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial/ 187 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/621 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 639 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial/ 639 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 635/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial/ 635/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 635/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial/ 635/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 635/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial/ 635 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial/ 635/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/443/ rebuild
https:/