Merge lp:~ken-vandine/messaging-framework/packaging_cleanup into lp:messaging-framework

Proposed by Ken VanDine
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 76
Merged at revision: 71
Proposed branch: lp:~ken-vandine/messaging-framework/packaging_cleanup
Merge into: lp:messaging-framework
Diff against target: 126 lines (+38/-12)
7 files modified
debian/control (+12/-9)
debian/libmessaging-fw-dev.install (+1/-0)
debian/libmessaging-fw1.install (+1/-1)
debian/source/format (+0/-1)
src/CMakeLists.txt (+8/-0)
src/utils.cpp (+0/-1)
tests/mock_group_starter.h (+16/-0)
To merge this branch: bzr merge lp:~ken-vandine/messaging-framework/packaging_cleanup
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Gustavo Pichorim Boiko (community) Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+309971@code.launchpad.net

Commit message

Packaging related fixes

Description of the change

Some packaging cleanup

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:75
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/92/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1929/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1930
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1769/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1769/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1769/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1769
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1769/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/92/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:76
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/93/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1930/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1931
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1770/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1770/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1770/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1770
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1770/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/93/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

LGTM

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-autoland/39/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1938/console
    None: https://jenkins.canonical.com/system-apps/job/lp-generic-land-mp/56/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1939
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1778/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1778/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1778/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1778
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1778/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good! Thanks for the fixes!

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-autoland/40/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1939/console
    None: https://jenkins.canonical.com/system-apps/job/lp-generic-land-mp/57/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1940
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1779/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1779/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1779/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1779
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1779/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-autoland/41/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1951/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1952
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1791/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1791
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1791/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1791/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2016-07-08 08:25:39 +0000
+++ debian/control 2016-11-03 16:28:03 +0000
@@ -1,9 +1,10 @@
1Source: messaging-framework1Source: messaging-framework
2Section: libs
2Priority: optional3Priority: optional
3Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
4Build-Depends: astyle,5Build-Depends: astyle,
6 clang-format-3.5:native,
5 clang:native,7 clang:native,
6 clang-format-3.5:native,
7 cmake,8 cmake,
8 debhelper (>= 9),9 debhelper (>= 9),
9 dos2unix,10 dos2unix,
@@ -18,29 +19,31 @@
18 libboost-system-dev,19 libboost-system-dev,
19 libdbus-cpp-dev,20 libdbus-cpp-dev,
20 libgoogle-glog-dev,21 libgoogle-glog-dev,
22 libphonenumber-dev,
21 libprocess-cpp-dev,23 libprocess-cpp-dev,
24 libsystemd-dev,
22 libtelepathy-qt5-dev,25 libtelepathy-qt5-dev,
23 libphonenumber-dev,
24 pkg-config,26 pkg-config,
25 qtbase5-dev,27 qtbase5-dev,
26 qtpim5-dev,28 qtpim5-dev,
27 telepathy-mission-control-5,29 telepathy-mission-control-5
28 libsystemd-dev30Standards-Version: 3.9.7
29Standards-Version: 3.9.5
30Section: libs
31Homepage: https://launchpad.net/messaging-framework31Homepage: https://launchpad.net/messaging-framework
32Vcs-Bzr: https://code.launchpad.net/~phablet-team/messaging-framework/trunk32Vcs-Bzr: https://code.launchpad.net/~phablet-team/messaging-framework/trunk
3333
34Package: libmessaging-fw-dev34Package: libmessaging-fw-dev
35Section: libdevel35Section: libdevel
36Architecture: any36Architecture: any
37Depends: libmessaging-fw (= ${binary:Version})37Multi-Arch: same
38Depends: libmessaging-fw1 (= ${binary:Version}), ${misc:Depends}
38Description: Ubuntu Messaging Framework header files39Description: Ubuntu Messaging Framework header files
40 All the development headers and libraries for the Messaging Framework
3941
40Package: libmessaging-fw42Package: libmessaging-fw1
41Section: libs43Section: libs
42Architecture: any44Architecture: any
43Depends: ${shlibs:Depends}, ${misc:Depends}45Multi-Arch: same
46Depends: ${misc:Depends}, ${shlibs:Depends}
44Description: Ubuntu Messaging Framework to build IM plugins47Description: Ubuntu Messaging Framework to build IM plugins
45 This layer communicates third party plugins with systems like48 This layer communicates third party plugins with systems like
46 telepathy allowing changing the system by other without having49 telepathy allowing changing the system by other without having
4750
=== modified file 'debian/libmessaging-fw-dev.install'
--- debian/libmessaging-fw-dev.install 2016-03-30 19:19:19 +0000
+++ debian/libmessaging-fw-dev.install 2016-11-03 16:28:03 +0000
@@ -1,2 +1,3 @@
1usr/include/messaging-fw/*1usr/include/messaging-fw/*
2usr/lib/*/libmessaging-fw*.so
2usr/lib/*/pkgconfig/messaging-fw.pc3usr/lib/*/pkgconfig/messaging-fw.pc
34
=== renamed file 'debian/libmessaging-fw.install' => 'debian/libmessaging-fw1.install'
--- debian/libmessaging-fw.install 2016-03-30 19:19:19 +0000
+++ debian/libmessaging-fw1.install 2016-11-03 16:28:03 +0000
@@ -1,2 +1,2 @@
1usr/lib/*/libmessaging-fw*.so*1usr/lib/*/libmessaging-fw*.so.*
2usr/lib/*/messaging-fw-runner2usr/lib/*/messaging-fw-runner
33
=== removed directory 'debian/source'
=== removed file 'debian/source/format'
--- debian/source/format 2016-06-23 05:48:49 +0000
+++ debian/source/format 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
13.0 (native)
20
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2016-09-17 21:42:07 +0000
+++ src/CMakeLists.txt 2016-11-03 16:28:03 +0000
@@ -65,6 +65,14 @@
65 ${MESSAGING_FW_SRCS}65 ${MESSAGING_FW_SRCS}
66)66)
6767
68set_target_properties(
69 messaging-fw
70
71 PROPERTIES
72 VERSION ${SO_VERSION_MAJOR}.${SO_VERSION_MINOR}.${SO_VERSION_PATCH}
73 SOVERSION ${SO_VERSION_MAJOR}
74)
75
68target_link_libraries(76target_link_libraries(
69 messaging-fw77 messaging-fw
7078
7179
=== removed file 'src/utils.cpp'
--- src/utils.cpp 2016-05-30 16:43:03 +0000
+++ src/utils.cpp 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1
20
=== modified file 'tests/mock_group_starter.h'
--- tests/mock_group_starter.h 2016-09-28 12:26:21 +0000
+++ tests/mock_group_starter.h 2016-11-03 16:28:03 +0000
@@ -1,3 +1,19 @@
1/*
2 * Copyright © 2016 Canonical Ltd.
3 *
4 * This program is free software: you can redistribute it and/or modify it
5 * under the terms of the GNU Lesser General Public License version 3,
6 * as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
1#ifndef TESTING_MOCK_GROUP_STARTER_H17#ifndef TESTING_MOCK_GROUP_STARTER_H
2#define TESTING_MOCK_GROUP_STARTER_H18#define TESTING_MOCK_GROUP_STARTER_H
319

Subscribers

People subscribed via source and target branches