Merge lp:~ken-vandine/gallery-app/add_profile into lp:gallery-app

Proposed by Ken VanDine
Status: Merged
Approved by: Arthur Mello
Approved revision: 1335
Merged at revision: 1345
Proposed branch: lp:~ken-vandine/gallery-app/add_profile
Merge into: lp:gallery-app
Diff against target: 53 lines (+18/-0)
4 files modified
debian/apparmor/gallery-app (+15/-0)
debian/control (+1/-0)
debian/gallery-app.install (+1/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~ken-vandine/gallery-app/add_profile
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
system-apps-ci-bot continuous-integration Approve
Review via email: mp+312280@code.launchpad.net

Commit message

added apparmor profile for gallery-app

Description of the change

added apparmor profile for gallery-app

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1334
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/29/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2099/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2102
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1931
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1931/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1931/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1931/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1931
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1931/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1931/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1931/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1931
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1931/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1931/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1931/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/29/rebuild

review: Needs Fixing (continuous-integration)
1335. By Ken VanDine

build dep on dh-apparmor

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1335
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/30/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2102
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/518
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2105
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1933/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1933
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1933/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/30/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'debian/apparmor'
=== added file 'debian/apparmor/gallery-app'
--- debian/apparmor/gallery-app 1970-01-01 00:00:00 +0000
+++ debian/apparmor/gallery-app 2016-12-01 18:15:27 +0000
@@ -0,0 +1,15 @@
1# vim:syntax=apparmor
2#include <tunables/global>
3
4# Mostly unconfined. Don't allow capability or any mount rules. Also ensure that
5# exec inherits from this profile
6profile gallery-app (attach_disconnected) {
7 network,
8 / rwkl,
9 /** rwlkm,
10 /** pix,
11 dbus,
12 signal,
13 ptrace,
14 unix,
15}
016
=== modified file 'debian/control'
--- debian/control 2016-09-21 19:06:33 +0000
+++ debian/control 2016-12-01 18:15:27 +0000
@@ -5,6 +5,7 @@
5Build-Depends: debhelper (>= 9),5Build-Depends: debhelper (>= 9),
6 cmake,6 cmake,
7 pkg-config,7 pkg-config,
8 dh-apparmor,
8 dh-translations,9 dh-translations,
9 libexiv2-dev,10 libexiv2-dev,
10 libgl1-mesa-dev | libgl-dev,11 libgl1-mesa-dev | libgl-dev,
1112
=== modified file 'debian/gallery-app.install'
--- debian/gallery-app.install 2016-01-14 20:08:09 +0000
+++ debian/gallery-app.install 2016-12-01 18:15:27 +0000
@@ -5,3 +5,4 @@
5usr/share/icons5usr/share/icons
6usr/share/locale/*/LC_MESSAGES/gallery-app.mo6usr/share/locale/*/LC_MESSAGES/gallery-app.mo
7usr/share/url-dispatcher/urls/*7usr/share/url-dispatcher/urls/*
8debian/apparmor/gallery-app etc/apparmor.d
89
=== modified file 'debian/rules'
--- debian/rules 2015-05-08 12:58:41 +0000
+++ debian/rules 2016-12-01 18:15:27 +0000
@@ -11,6 +11,7 @@
1111
12override_dh_install:12override_dh_install:
13 dh_install --fail-missing13 dh_install --fail-missing
14 dh_apparmor -pgallery-app --profile-name=gallery-app
1415
15override_dh_translations:16override_dh_translations:
16 # Override dh_translations to work around http://pad.lv/1183262.17 # Override dh_translations to work around http://pad.lv/1183262.

Subscribers

People subscribed via source and target branches